Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Fix searching in groups #2825

Merged
merged 1 commit into from Jan 27, 2021
Merged

fix(frontend): Fix searching in groups #2825

merged 1 commit into from Jan 27, 2021

Conversation

Desvelao
Copy link
Member

Hi team, this PR resolves:

  • Fix searching of groups in Management > Groups
    • Reset to 0 the items after search.
    • Add loading status.
    • Add toast when getting the groups fails.

Closes: #2812

@Desvelao
fix(frontend): Fix search in groups:
db4221d 
  - Add loading status
  - Add toast when getting the groups fails
@Desvelao Desvelao added the type/bug Bug issue label Jan 25, 2021
@Desvelao Desvelao added this to the Sprint 123 - WUI milestone Jan 25, 2021
@Desvelao Desvelao self-assigned this Jan 25, 2021
frankeros
frankeros approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao linked an issue Jan 25, 2021 that may be closed by this pull request
Group search shows all groups when groupname has "strange characters" #2812
Closed
pablomarga
pablomarga approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 772757d into 4.0-7.10 Jan 27, 2021
@frankeros frankeros deleted the fix/2812-fix-groups-search branch January 27, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankeros frankeros frankeros approved these changes

@pablomarga pablomarga pablomarga approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
Sprint 123 - WUI
Development

Successfully merging this pull request may close these issues.

Group search shows all groups when groupname has "strange characters"
3 participants
@Desvelao @frankeros @pablomarga