Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.4-7.10.0] Fixed accordion style breaking #2833

Merged
merged 2 commits into from Jan 27, 2021
Merged

[4.0.4-7.10.0] Fixed accordion style breaking #2833

merged 2 commits into from Jan 27, 2021

Conversation

frankeros
Copy link
Contributor

Hi team, this resolves

  • The inventory.scss is breaking all accordions style when it's loaded by the browser.
    image

gabiwassan
gabiwassan approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Desvelao Desvelao self-requested a review January 26, 2021 13:38
@Desvelao
Copy link
Member

Desvelao commented Jan 26, 2021 •
edited

I tested the PR and some sections as the MITRE flyout should too be fixed. Perhaps there could be more sections with this problem.
image
image

These files contain more flyout with this problem:

  • public/components/overview/compliance-table/components/requirement-flyout/requirement-flyout.tsx
  • public/components/overview/mitre/components/techniques/components/flyout-technique/flyout-technique.tsx

@frankeros
Copy link
Contributor Author

I tested the PR and some sections as the MITRE flyout should too be fixed. Perhaps there could be more sections with this problem.
image
image

These files contain more flyout with this problem:

* `public/components/overview/compliance-table/components/requirement-flyout/requirement-flyout.tsx`

* `public/components/overview/mitre/components/techniques/components/flyout-technique/flyout-technique.tsx`

I push a new commit to solve this too. Thanks!

pablomarga
pablomarga approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 144b808 into 4.0-7.10 Jan 27, 2021
@frankeros frankeros deleted the bugfix/inventory-style-is-breaking-all-accordion-styles branch January 27, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan approved these changes

@pablomarga pablomarga pablomarga approved these changes

@Desvelao Desvelao Awaiting requested review from Desvelao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frankeros @Desvelao @gabiwassan @pablomarga