Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2840 search file editor gone #2843

Merged
merged 2 commits into from Jan 26, 2021

Conversation

asteriscos
Copy link
Member

Hi team, this PR fixes:

The search feature in the configuration file editor.
Elastic UI Code editor requires to load the search module externally.

Closes: #2840

Additional information:
thlorenz/brace#62 (comment)

@asteriscos asteriscos requested a review from a team January 26, 2021 14:39
@asteriscos asteriscos linked an issue Jan 26, 2021 that may be closed by this pull request
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Desvelao
Copy link
Member

Desvelao commented Jan 26, 2021

I tested the PR with ODFE 1.12.0 and it is working:

Management > Configuration
image

Management > Decoders
image

Management > Groups
image

Management > Rules
image

Security > Roles mapping > Rule editor
image

@Desvelao Desvelao added the type/bug Bug issue label Jan 26, 2021
@Desvelao Desvelao added this to the Sprint 123 - WUI milestone Jan 26, 2021
@Desvelao Desvelao self-requested a review January 26, 2021 17:21
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit 21fa998 into 4.0-7.10 Jan 26, 2021
@Desvelao Desvelao deleted the bugfix/2840-search-file-editor-gone branch January 26, 2021 17:57
@frankeros frankeros mentioned this pull request Jan 28, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The search functionality in file editor is gone
3 participants