Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove discover] Refactor angularJS groups.js #6540

Closed
Tracked by #6535
lucianogorza opened this issue Mar 20, 2024 · 1 comment · Fixed by #6543
Closed
Tracked by #6535

[Remove discover] Refactor angularJS groups.js #6540

lucianogorza opened this issue Mar 20, 2024 · 1 comment · Fixed by #6543
Assignees
Labels
level/subtask Subtask issue type/enhancement Enhancement issue

Comments

@lucianogorza
Copy link
Member

lucianogorza commented Mar 20, 2024

Description

To deprecate angularJS in the plugins we need to refactor the groups.js into a react component.
The file is located in: /plugins/main/public/controllers/management/groups.js

@lucianogorza lucianogorza self-assigned this Mar 20, 2024
@lucianogorza lucianogorza added type/enhancement Enhancement issue level/subtask Subtask issue labels Mar 20, 2024
@lucianogorza lucianogorza removed their assignment Mar 20, 2024
@lucianogorza lucianogorza changed the title [Remove discover] Refactor angularJS agents.js [Remove discover] Refactor angularJS groups.js Mar 20, 2024
@lucianogorza
Copy link
Member Author

lucianogorza commented Mar 20, 2024

Update 20/03/2024

Analyze files and dependencies

  • Controller to be removed: plugins/main/public/controllers/management/groups.js.
  • Files in the directory plugins/main/public/controllers/management/components/management/groups/ correspond to the components for group management, and the dependencies of the controller to be removed are few.
  • On the other hand, there is the component plugins/main/public/components/management/groups/multiple-agent-selector.tsx used for editing agents in a group.
  • Finally, the template plugins/main/public/templates/management/management.html has a section for groups where it only displays the MultipleAgentSelector component according to certain conditions.

To remove the controller, it is necessary for the MultipleAgentSelector component to be controlled by the main groups component, WzGroups, and to handle passing the props that are currently being passed by the controller.

@lucianogorza lucianogorza linked a pull request Mar 20, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/subtask Subtask issue type/enhancement Enhancement issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants