Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Dev-tools shows "self.getPosition is not a function" when debugging in browser #1587

Closed
jesusgn90 opened this issue Jul 12, 2019 · 2 comments
Assignees
Labels
type/bug Bug issue
Projects

Comments

@jesusgn90
Copy link
Contributor

Wazuh Elastic Rev
3.9.3 6.8 448

Description
Something is wrong in the latest 6.x app and the DevTools tab, it seems like a function is not being declared, or the scope of this is not reachable.

Steps to reproduce

  1. Go to DevTools
  2. Open the dev tools from your browser
  3. A fatal Kibana error appears

Screenshots

image

@jesusgn90 jesusgn90 added this to To do in Wazuh 3.9.3 via automation Jul 12, 2019
@juankaromo
Copy link
Contributor

juankaromo commented Jul 12, 2019

Hi team,

The getPosition method (in charge of calculating the position of the dev tools with respect to the window in order to restore it to a dynamic height) had disappeared. It seems to be due to some merge or cherry-pick from 7.2. Also, the method of resizing the columns has been fixed because it did not take into account the width of the side menu of Kibana 6.8 (again because of 7.X).

Regards.

@jesusgn90 jesusgn90 moved this from To do to In progress in Wazuh 3.9.3 Jul 12, 2019
@juankaromo juankaromo moved this from In progress to Needs review in Wazuh 3.9.3 Jul 12, 2019
@juankaromo
Copy link
Contributor

Hi team,

As believed, the getPosition() method had been removed. It has been added again and everything works correctly by resizing the window.

https://github.com/wazuh/wazuh-kibana-app/blob/0d17edbb19cd644db4b8c06649e2c19ecebbc119/public/controllers/dev-tools/dev-tools.js#L632-L644

On the other hand, the method of resizing the columns has been corrected by adding the width of the Kibana sidebar to the calculation (215 px).

https://github.com/wazuh/wazuh-kibana-app/blob/0d17edbb19cd644db4b8c06649e2c19ecebbc119/public/controllers/dev-tools/dev-tools.js#L430

Regards.

Wazuh 3.9.3 automation moved this from Needs review to Done Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
No open projects
Wazuh 3.9.3
  
Done
Development

No branches or pull requests

2 participants