Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0-7.10 Backend organization #2781

Merged
merged 7 commits into from
Jan 14, 2021
Merged

4.0-7.10 Backend organization #2781

merged 7 commits into from
Jan 14, 2021

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jan 14, 2021

Hi team, this PR:

  • Removed not used files (.old.js)
  • Renamed .js files to .ts
  • Renamed /util to /common
  • Moved /server/reporting to /server/lib/reporting
  • Moved /server/jobs/queue to /server/start/queue
  • Moved /server/logger to /server/lib/logger
  • Moved files in /util to /server/lib
  • Adapted imports in backend and frontend
  • Created index files for each backend job
  • Removed endpoints:
    • /api/pci/{requirement}
    • /api/gdpr/{requirement}
    • /api/nist/{requirement}
    • /api/tsc/{requirement}
    • /api/hipaa/{requirement}
    • /api/monitoring
    • /api/agents
    • /elastic/index-patterns
    • /reports
  • Renamed endpoint /elastic/esAlerts to /elastic/alerts. Adapted frontend
  • Removed files:
    • /server/lib/elastic-wrapper.ts
    • /server/lib/api-helper.js
    • /server/lib/get-path.ts
    • /server/lib/reporting/tab-description

  - Removed not used files (.old)
  - Renamed .js files to .ts
  - Renamed /util to /common
  - Moved /server/reporting to /server/lib/reporting
  - Moved /server/jobs/queue to /server/start/queue
  - Moved /server/logger to /server/lib/logger
  - Moved files in /util to /server/lib
  - Adapted imports in backend and frontend
  - Created index files for each backend job
@Desvelao Desvelao added this to the Sprint 122 - WUI milestone Jan 14, 2021
@Desvelao Desvelao self-assigned this Jan 14, 2021
@Desvelao Desvelao changed the base branch from master to 4.0-7.10 January 14, 2021 11:32
  - Removed endpoints:
    - /api/pci/{requirement}
    - /api/gdpr/{requirement}
    - /api/nist/{requirement}
    - /api/tsc/{requirement}
    - /api/hipaa/{requirement}
    - /api/monitoring
    - /api/agents
    - /elastic/index-patterns
  - Renamed endpoint /elastic/esAlerts to /elastic/alerts
  - Removed files:
    - /server/lib/elastic-wrapper.ts
    - /server/lib/api-helper.js
    - /server/lib/get-path.ts
@Desvelao Desvelao marked this pull request as ready for review January 14, 2021 11:40
@Desvelao
Copy link
Member Author

Fixed relative path imports of fonts and logo to create reports.

@Desvelao Desvelao mentioned this pull request Jan 14, 2021
5 tasks
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@frankeros frankeros merged commit b218bce into 4.0-7.10 Jan 14, 2021
@frankeros frankeros deleted the 4.0-7.10-organize-backend branch January 14, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants