Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement try catch strategy Security #3390

Merged
merged 5 commits into from
Jun 30, 2021
Merged

Implement try catch strategy Security #3390

merged 5 commits into from
Jun 30, 2021

Conversation

pablomarga
Copy link
Contributor

@pablomarga pablomarga commented Jun 23, 2021 •
edited
Loading

Hi team,
This PR implement our new error handling strategy on Security section

Close #3394

@pablomarga pablomarga requested a review from a team June 23, 2021 15:57
@pablomarga pablomarga self-assigned this Jun 23, 2021
gabiwassan
gabiwassan suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! just some details. 💪🏼

public/components/security/main.tsx Outdated Show resolved Hide resolved
public/components/security/policies/create-policy.tsx Outdated Show resolved Hide resolved
public/components/security/policies/policies-table.tsx Outdated Show resolved Hide resolved
@gabiwassan gabiwassan requested a review from a team June 23, 2021 19:18
gabiwassan
gabiwassan approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

@gabiwassan gabiwassan merged commit 7374ae3 into 4.3-7.10 Jun 30, 2021
@gabiwassan gabiwassan deleted the feature/implement-try-catch-policies branch June 30, 2021 19:33
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@pablomarga pablomarga

Labels
error-handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pablomarga @Machi3mfl @gabiwassan