Implement try catch strategy in Ruleset #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiwassan
suggested changes
Jun 29, 2021
public/controllers/management/components/management/ruleset/actions-buttons.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/actions-buttons.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/decoder-info.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/rule-info.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/ruleset-editor.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/ruleset-filter-bar.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/ruleset-filter-bar.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/ruleset-table.js
Outdated
Show resolved
Hide resolved
frankeros
reviewed
Jun 29, 2021
public/controllers/management/components/management/ruleset/actions-buttons.js
Outdated
Show resolved
Hide resolved
frankeros
reviewed
Jun 29, 2021
public/controllers/management/components/management/ruleset/rule-info.js
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/ruleset-editor.js
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/ruleset/ruleset-editor.js
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Jun 30, 2021
public/controllers/management/components/management/ruleset/actions-buttons.js
Show resolved
Hide resolved
Desvelao
reviewed
Jun 30, 2021
public/controllers/management/components/management/ruleset/decoder-info.js
Outdated
Show resolved
Hide resolved
gabiwassan
approved these changes
Jul 1, 2021
| const logtestProps = ''; | ||
| const clusterStatus = ''; | ||
| const wrapper = mount(<WzRuleset logtestProps={logtestProps} clusterStatus={clusterStatus} />); | ||
| expect(wrapper).toMatchSnapshot(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR implement our new error handling strategy on the Ruleset section
Close #3409