-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor try catch in Management > Status #3434
Merged
gabiwassan
merged 11 commits into
4.3-7.10
from
feature/3427-implement-try-catch-strategy-status
Jul 16, 2021
Merged
Refactor try catch in Management > Status #3434
gabiwassan
merged 11 commits into
4.3-7.10
from
feature/3427-implement-try-catch-strategy-status
Jul 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machi3mfl
changed the title
implemented try catch strategy Status section
Implemented try catch strategy Management > Status section
Jul 2, 2021
Machi3mfl
changed the title
Implemented try catch strategy Management > Status section
Added try catch strategy with ErrorOrchestrator service on Management > Status
Jul 2, 2021
Desvelao
reviewed
Jul 5, 2021
public/controllers/management/components/management/status/actions-buttons-main.js
Outdated
Show resolved
Hide resolved
25 tasks
Machi3mfl
changed the title
Added try catch strategy with ErrorOrchestrator service on Management > Status
Refactor try catch in Management > Status
Jul 5, 2021
matiasmoreno876
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: LGTM!
frankeros
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gabiwassan
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
* test(unittest): Updating test. * test(unittest): Updating test.
|
Machi3mfl
added a commit
that referenced
this pull request
Jul 19, 2021
* Added try-catc new strategy * Added test file and component snapshot * Updated CHANGELOG * Updating error title and message * Refactor try catch in Management > Statistics (#3429) * Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Merged conflicts * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * merged CHANGELOG Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
gabiwassan
added a commit
that referenced
this pull request
Aug 5, 2021
* Added try-catc new strategy * Added test file and component snapshot * Updated CHANGELOG * Updating error title and message * Refactor try catch in Management > Statistics (#3429) * Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Merged conflicts * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * merged CHANGELOG Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR implement our new error handling strategy on the Status section
Close #3433