Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor try catch in Management > Status #3434

Merged
merged 11 commits into from
Jul 16, 2021

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Jul 2, 2021

Hi team,
This PR implement our new error handling strategy on the Status section

Close #3433

@Machi3mfl Machi3mfl self-assigned this Jul 2, 2021
@Machi3mfl Machi3mfl changed the title implemented try catch strategy Status section Implemented try catch strategy Management > Status section Jul 2, 2021
@Machi3mfl Machi3mfl changed the title Implemented try catch strategy Management > Status section Added try catch strategy with ErrorOrchestrator service on Management > Status Jul 2, 2021
@Machi3mfl Machi3mfl requested a review from a team July 2, 2021 20:01
@Machi3mfl Machi3mfl changed the title Added try catch strategy with ErrorOrchestrator service on Management > Status Refactor try catch in Management > Status Jul 5, 2021
@Machi3mfl Machi3mfl requested a review from Desvelao July 8, 2021 15:41
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!

Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gabiwassan and others added 6 commits July 13, 2021 15:10
* Added error handling implementation

* Changed wrong var err

* Draft statistics test and snapshot

* Updated CHANGELOG

* Updating title and message error

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
* test(unittest): Updating test.

* test(unittest): Updating test.
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.06% ( 1090 / 35564 )
Branches 1.13% ( 315 / 27939 )
Functions 1.96% ( 169 / 8642 )
Lines 3.1% ( 1053 / 33991 )

@MauGaP MauGaP self-assigned this Jul 14, 2021
@gabiwassan gabiwassan merged commit a70e461 into 4.3-7.10 Jul 16, 2021
@gabiwassan gabiwassan deleted the feature/3427-implement-try-catch-strategy-status branch July 16, 2021 15:57
Machi3mfl added a commit that referenced this pull request Jul 19, 2021
* Added try-catc new strategy

* Added test file and component snapshot

* Updated CHANGELOG

* Updating error title and message

* Refactor try catch in Management > Statistics (#3429)

* Added error handling implementation

* Changed wrong var err

* Draft statistics test and snapshot

* Updated CHANGELOG

* Updating title and message error

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* Merged conflicts

* Updating test. (#3470)

* test(unittest): Updating test.

* test(unittest): Updating test.

* merged CHANGELOG

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
gabiwassan added a commit that referenced this pull request Aug 5, 2021
* Added try-catc new strategy

* Added test file and component snapshot

* Updated CHANGELOG

* Updating error title and message

* Refactor try catch in Management > Statistics (#3429)

* Added error handling implementation

* Changed wrong var err

* Draft statistics test and snapshot

* Updated CHANGELOG

* Updating title and message error

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>

* Merged conflicts

* Updating test. (#3470)

* test(unittest): Updating test.

* test(unittest): Updating test.

* merged CHANGELOG

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants