Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Code overflows over the line numbers in API Console editor #3439

Merged
merged 3 commits into from
Jul 19, 2021
Merged

[Fix] Code overflows over the line numbers in API Console editor #3439

merged 3 commits into from
Jul 19, 2021

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jul 6, 2021 •
edited
Loading

Description

Fix the code overflows over the line numbers in the API Console editor.

Test

  1. Go to the API Console editor and scroll the left panel (where you can edit the API request) to the right and the text shouldn't overflow the line numbers.

Closes #3339

@Desvelao Desvelao added the type/bug Bug issue label Jul 6, 2021
@Desvelao Desvelao self-assigned this Jul 6, 2021
@Desvelao Desvelao linked an issue Jul 6, 2021 that may be closed by this pull request
API console text overflows over the line numbers when scrolling to the right. #3339
Closed
pablomarga
pablomarga reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Testing: ✔️

mpRegalado
mpRegalado approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM ✔️
Testing: LGTM ✔️

frankeros
frankeros approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

matiasmoreno876
matiasmoreno876 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!

@frankeros frankeros merged commit f062103 into 4.3-7.10 Jul 19, 2021
@frankeros frankeros deleted the fix/3339-z-index-code-console-editor branch July 19, 2021 18:29
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.12% ( 1109 / 35572 )
Branches 1.16% ( 324 / 27937 )
Functions 2.02% ( 174 / 8632 )
Lines 3.15% ( 1071 / 33990 )

Machi3mfl pushed a commit that referenced this pull request Jul 19, 2021
@Desvelao @Machi3mfl
[Fix] Code overflows over the line numbers in API Console editor (#3439)
4fb7176
gabiwassan pushed a commit that referenced this pull request Aug 5, 2021
@Desvelao @gabiwassan
[Fix] Code overflows over the line numbers in API Console editor (#3439)
776102b
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablomarga pablomarga pablomarga left review comments

@frankeros frankeros frankeros approved these changes

@matiasmoreno876 matiasmoreno876 matiasmoreno876 approved these changes

@mpRegalado mpRegalado mpRegalado approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API console text overflows over the line numbers when scrolling to the right.
5 participants
@Desvelao @frankeros @pablomarga @matiasmoreno876 @mpRegalado