Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added time subscription in discover component #3549

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Added time subscription in discover component #3549

merged 3 commits into from
Aug 10, 2021

Conversation

mpRegalado
Copy link
Member

This pr closes #3522

We have added a time subscription to the lifecycle of the component Discover to change it's own timestate.

To test:

  1. Go to the Office365 panel
  2. Visit any drilldown
  3. Change the time range in the search bar
  4. See that the event table updates

@mpRegalado mpRegalado self-assigned this Aug 10, 2021
@mpRegalado mpRegalado requested review from Desvelao and a team August 10, 2021 07:17
CPAlejandro
CPAlejandro approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR:🟢
Testing:🟢

@CPAlejandro CPAlejandro linked an issue Aug 10, 2021 that may be closed by this pull request
SecurtyAlerts does not update automatically #3522
Closed
eze9252
eze9252 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpRegalado mpRegalado merged commit 7a0b2fd into feature/Office365 Aug 10, 2021
@mpRegalado mpRegalado deleted the bugfix/3522_added-time-subscription-discover branch August 10, 2021 08:32
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@eze9252 eze9252 eze9252 approved these changes

@Desvelao Desvelao Awaiting requested review from Desvelao

Assignees

@mpRegalado mpRegalado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SecurtyAlerts does not update automatically
3 participants
@mpRegalado @CPAlejandro @eze9252