Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add id when agent is not pinned #3689

Merged
merged 4 commits into from Nov 30, 2021
Merged

Add id when agent is not pinned #3689

merged 4 commits into from Nov 30, 2021

Conversation

yenienserrano
Copy link
Member

Description
It was added to see the ID of the agent that corresponds to the file that you want to see, since the ID of the pinned agent was being taken only

Issue

The registry values of are not displayed in FIM - Events #3677

Test

Preconditions
Without an agent selected.

Steps

  1. Navigate to 'FIM/Events'
  2. Click on the syscheck.path value of a Windows registry
  3. See if the registry value table is not empty.
  4. Pin an agent
  5. Click on the syscheck.path value of a Windows registry
  6. See if the registry value table is not empty.

Check List

  • See registry values ​​with a pinned agent
  • See registry values ​​without a pinned agent

Screenshots

Without an agent selected

image

With an agent selected

image

@yenienserrano yenienserrano added the type/bug Bug issue label Nov 18, 2021
@yenienserrano yenienserrano self-assigned this Nov 18, 2021
@yenienserrano yenienserrano mentioned this pull request Nov 18, 2021
Closed
gabiwassan
gabiwassan approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yenienserrano yenienserrano linked an issue Nov 29, 2021 that may be closed by this pull request
The registry values of are not displayed in FIM - Events #3677
Closed
Machi3mfl
Machi3mfl approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!
@yenienserrano Please, fix branch conflicts.

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.97% ( 1443 / 36353 )
Branches 1.6% ( 453 / 28400 )
Functions 2.91% ( 259 / 8891 )
Lines 4.02% ( 1398 / 34741 )

@Machi3mfl Machi3mfl added the 4.3 label Nov 30, 2021
@MauGaP MauGaP changed the base branch from 4.3-7.10 to 4.3-7.10---RC1 November 30, 2021 13:59
@MauGaP MauGaP merged commit 0b826d0 into 4.3-7.10---RC1 Nov 30, 2021
@MauGaP MauGaP deleted the fix/3677-the-registry-values-of-are-not-displayed-in-fim-events branch November 30, 2021 13:59
@MauGaP MauGaP mentioned this pull request Dec 1, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@yenienserrano yenienserrano

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The registry values of are not displayed in FIM - Events
5 participants
@yenienserrano @Machi3mfl @gabiwassan @MauGaP @eze9252