Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [Monitoring] Retrieve data of all agents #3728

Merged

Conversation

Desvelao
Copy link
Member

Description

This PR fixes the problem of only index data of the first 500 agents in the monitoring job.

Changes

  • Fixed the limit query param to 500 for each request. This could be improved as described in a comment included in the PR changes but require researching.

Tests

  • With monitoring job running (and permission to do) and more than 500 agents check the Evolution visualization displays more than 500 as the sum of different agent status

Closes #3717

  - Fixed the limit of results to retrieve to 500.
  - This logic could be improved with select data and increase the limit of results. See the commint included in this commit
@Desvelao Desvelao added the type/bug Bug issue label Dec 15, 2021
@Desvelao Desvelao requested a review from a team December 15, 2021 09:24
@Desvelao Desvelao self-assigned this Dec 15, 2021
@Desvelao Desvelao linked an issue Dec 15, 2021 that may be closed by this pull request
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@yenienserrano
Copy link
Member

LGTM

@Desvelao Desvelao merged commit 51db18f into 4.3-7.10---RC1 Dec 17, 2021
@Desvelao Desvelao deleted the fix/3717-monitoring-not-retrieve-data-all-agents branch December 17, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evolution histogram in Agents Preview shows max 500 agents
3 participants