Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance agent deployment UI #3792

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Enhance agent deployment UI #3792

merged 4 commits into from
Jan 12, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jan 7, 2022 •
edited by Desvelao
Loading

Hi team,

this PR enhances the user experience when trying to copy an agent install code block. Also warns the user that the Windows script must be run in a PowerShell terminal.

Closes #3762

Peek 2022-01-07 17-11

Tests

  • This should be tested with different browsers.

@asteriscos asteriscos added the 4.3 label Jan 7, 2022
@asteriscos asteriscos self-assigned this Jan 7, 2022
@Desvelao
Copy link
Member

nitpick Use PowerShell instead of powershell

@Desvelao Desvelao linked an issue Jan 10, 2022 that may be closed by this pull request
Improve agent deployment UI #3762
Closed
@Desvelao Desvelao added the type/enhancement Enhancement issue label Jan 10, 2022
@yenienserrano yenienserrano self-requested a review January 11, 2022 17:44
yenienserrano
yenienserrano approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR y Test: ✔️
LGTM

matiasmoreno876
matiasmoreno876 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM ✅

@matiasmoreno876 matiasmoreno876 merged commit 55b3e39 into 4.3-7.10-RC2 Jan 12, 2022
@matiasmoreno876 matiasmoreno876 deleted the enhance/improve-agent-deployment-ui-3762 branch January 12, 2022 13:37
@Mayons Mayons mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@matiasmoreno876 matiasmoreno876 matiasmoreno876 approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@asteriscos asteriscos

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve agent deployment UI
4 participants
@asteriscos @Desvelao @matiasmoreno876 @yenienserrano