Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub configuration panel text overflow #3945

Merged
merged 2 commits into from
Apr 6, 2022
Merged

GitHub configuration panel text overflow #3945

merged 2 commits into from
Apr 6, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Apr 4, 2022 •
edited
Loading

Hi team,

this fixed the github and office 365 configuration panels overflow when a field was very long.

Closes #3938

To test it generate a very long field to show in the panel, like the github auth token and check it renders properly.

image

@asteriscos asteriscos requested a review from Desvelao April 4, 2022 15:40
@asteriscos asteriscos self-assigned this Apr 4, 2022
@asteriscos asteriscos changed the base branch from master to 4.3-7.10 April 4, 2022 15:40
@asteriscos asteriscos added the 4.3 label Apr 4, 2022
yenienserrano
yenienserrano approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

@Desvelao
Copy link
Member

Desvelao commented Apr 6, 2022

review
Code review ❌
Add the change in the changelog file.

@Desvelao
Copy link
Member

Desvelao commented Apr 6, 2022

Changes

  • Added change to the changelog
  • Added entry to the changelog with the additions of GitHub and Office365 modules

Desvelao
Desvelao approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Code review ✔️
Test ✔️

@Desvelao Desvelao merged commit 602302d into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the fix/github-configuration-panel-overflow-3938 branch April 6, 2022 07:44
@Desvelao Desvelao mentioned this pull request Apr 6, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36559 )
Branches 1.61% ( 459 / 28480 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34951 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github integration panel information overflows panel limits
3 participants
@asteriscos @Desvelao @yenienserrano