Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed breadcrumb agent push #4101

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Apr 26, 2022

Description

This PR a main-overview.tsx leftover code. When globalBreadcrumb.tsx was refactored to centralize the agent routing, main-overview should have been modified to just send the agent information, so globalBreadcrumb creates the routing object.

Closes #4093

Steps to reproduce

  • Go to Agents > Name of the agent > System auditing
  • Return to the agent summary menu
  • See the undefined router error in the console

image

Additional information

The class WzCurrentAgentsSection also has deprecated code and doesn't seem to be used by the application. I suggest creating an issue to clean code and remove deprecated classes, commented code, functions not being used, etc

Signed-off-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@asteriscos asteriscos added the 4.3 label Apr 26, 2022
@asteriscos asteriscos self-assigned this Apr 26, 2022
@asteriscos asteriscos linked an issue Apr 26, 2022 that may be closed by this pull request
Signed-off-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@MauGaP MauGaP self-requested a review April 26, 2022 12:47
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code review : passed
  • Test : passed

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36554 )
Branches 1.61% ( 459 / 28477 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34949 )

Copy link
Contributor

@MauGaP MauGaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Testing: passed

@Desvelao Desvelao merged commit f175b67 into 4.3-7.10 Apr 27, 2022
@Desvelao Desvelao deleted the fix/global-breadcrumb-undefined-router-4093 branch April 27, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError in System Auditing menu
4 participants