Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the getConfiguration backend service #5428

Merged
merged 6 commits into from
May 10, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented May 10, 2023

Description

This pull request enhances the backend service to get the plugin configuration.

Issues Resolved

#5427

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…guration

- Enhance the backend service to get the plugin configuration
- Tests:
  - Add testing for the getConfiguration service
  - Add test to ensure the `GET /utils/configuration` returns the expected host
    response
@Desvelao Desvelao requested a review from a team as a code owner May 10, 2023 14:56
@Desvelao Desvelao self-assigned this May 10, 2023
@Desvelao Desvelao linked an issue May 10, 2023 that may be closed by this pull request
@Tostti Tostti self-requested a review May 10, 2023 15:10
@Machi3mfl Machi3mfl self-requested a review May 10, 2023 15:16
Tostti
Tostti previously approved these changes May 10, 2023
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen
imagen
imagen

TEST:✔️
CR:✔️

LGTM

Machi3mfl
Machi3mfl previously approved these changes May 10, 2023
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

image

image

image

@Desvelao Desvelao dismissed stale reviews from Machi3mfl and Tostti via b6e5b1d May 10, 2023 18:09
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.77% ( 3241 / 36926 )
Branches 4.49% ( 1287 / 28640 )
Functions 7.63% ( 698 / 9146 )
Lines 8.84% ( 3126 / 35361 )

@asteriscos asteriscos merged commit 6290e99 into 4.4 May 10, 2023
3 checks passed
@asteriscos asteriscos deleted the fix/enhance-get-configuration-backend-service branch May 10, 2023 19:24
@github-actions
Copy link
Contributor

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5428-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6290e99887fb20f84e2dba21e4f1255d7ad4e69e
# Push it to GitHub
git push --set-upstream origin backport-5428-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5428-to-4.4-7.10.

@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5428-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6290e99887fb20f84e2dba21e4f1255d7ad4e69e
# Push it to GitHub
git push --set-upstream origin backport-5428-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5428-to-4.4-7.16.

Desvelao added a commit that referenced this pull request May 11, 2023
* fix(enhance): enhance the the backend service to get the plugin configuration

- Enhance the backend service to get the plugin configuration
- Tests:
  - Add testing for the getConfiguration service
  - Add test to ensure the `GET /utils/configuration` returns the expected host
    response

* changelog: add pull request entry

* changelog: fix changelog

* Fix get configuration test unlink command error

* fix: fix comment on unit test

---------

Co-authored-by: Maximiliano Ibarra <maximiliano.ibarra@wazuh.com>
(cherry picked from commit 6290e99)
Desvelao added a commit that referenced this pull request May 11, 2023
* fix(enhance): enhance the the backend service to get the plugin configuration

- Enhance the backend service to get the plugin configuration
- Tests:
  - Add testing for the getConfiguration service
  - Add test to ensure the `GET /utils/configuration` returns the expected host
    response

* changelog: add pull request entry

* changelog: fix changelog

* Fix get configuration test unlink command error

* fix: fix comment on unit test

---------

Co-authored-by: Maximiliano Ibarra <maximiliano.ibarra@wazuh.com>
(cherry picked from commit 6290e99)
asteriscos pushed a commit that referenced this pull request May 11, 2023
* Enhance the getConfiguration backend service (#5428)

* fix(enhance): enhance the the backend service to get the plugin configuration

- Enhance the backend service to get the plugin configuration
- Tests:
  - Add testing for the getConfiguration service
  - Add test to ensure the `GET /utils/configuration` returns the expected host
    response

* changelog: add pull request entry

* changelog: fix changelog

* Fix get configuration test unlink command error

* fix: fix comment on unit test

---------

Co-authored-by: Maximiliano Ibarra <maximiliano.ibarra@wazuh.com>
(cherry picked from commit 6290e99)

* fix: fix accessing to object key
asteriscos pushed a commit that referenced this pull request May 11, 2023
* Enhance the getConfiguration backend service (#5428)

* fix(enhance): enhance the the backend service to get the plugin configuration

- Enhance the backend service to get the plugin configuration
- Tests:
  - Add testing for the getConfiguration service
  - Add test to ensure the `GET /utils/configuration` returns the expected host
    response

* changelog: add pull request entry

* changelog: fix changelog

* Fix get configuration test unlink command error

* fix: fix comment on unit test

---------

Co-authored-by: Maximiliano Ibarra <maximiliano.ibarra@wazuh.com>
(cherry picked from commit 6290e99)

* fix: fix accessing to object key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the getConfiguration backend service
4 participants