Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigability redesign for the app #652

Merged
merged 14 commits into from Jul 2, 2018
Merged

Navigability redesign for the app #652

merged 14 commits into from Jul 2, 2018

Conversation

JuanjiJG
Copy link
Contributor

@JuanjiJG JuanjiJG commented Jul 2, 2018

Hello team,

This PR closes #616, and includes a new design iteration for the app.

navbar1
navbar2
navbar3
navbar4

As you can see on the screenshots, we've re-added the md-nav-bar component, but we've customized it to be smaller, and only limited to each section on each app tab. This means that you'll only have for example a md-nav-bar for all the System Audit section, and if you want to see a different one, you have to go to the Welcome tab first.

This PR also removes the Welcome tab from Settings, since there's no more than one section for all the sub-tabs.

This PR also includes some minor CSS improvements and file reordering.

I hope you like this redesign.

Regards,
Juanjo

@JuanjiJG JuanjiJG self-assigned this Jul 2, 2018
@JuanjiJG JuanjiJG added this to Pending in Revision 400 via automation Jul 2, 2018
@JuanjiJG JuanjiJG requested a review from havidarou July 2, 2018 15:13
@havidarou
Copy link
Member

LGTM! Great work!!!

@havidarou havidarou merged commit ebcb2b1 into 3.3-6.3 Jul 2, 2018
Revision 400 automation moved this from Pending to Testing Jul 2, 2018
@havidarou havidarou deleted the 3.3-6.3-nav-redesign branch July 2, 2018 15:38
@JuanjiJG JuanjiJG moved this from Testing to Done in Revision 400 Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Revision 400
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants