Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'test_feeds/msu/test_invalid_values_msu_feed' tests in 4.2 #1551

Closed
4 tasks
Tracked by #1531
damarisg opened this issue Jul 6, 2021 · 2 comments
Closed
4 tasks
Tracked by #1531

Fix 'test_feeds/msu/test_invalid_values_msu_feed' tests in 4.2 #1551

damarisg opened this issue Jul 6, 2021 · 2 comments

Comments

@damarisg
Copy link
Member

damarisg commented Jul 6, 2021

Issue information

Related issue
Closes #1531

When it comes to starting with the test fix, there is some information that can help you:

Module: Vulnerability Detector
Support Team:  "binary beasts"
Target: Manager   
OS: Linux

I add some information obtained while researched the logs that failed.

In this case, there 2 different errors when it failed. For that, I will create 2 cases but the test is the same.
The idea is that you can analyze and fix both.

Case 1:

Type Description
Test Path test_feeds/msu/test_invalid_values_msu_feed
Consistent yes
Test Execution 3/3 executions failed
Cases Fails 93
Summary On modify_feed method when called read_json_file. The problem seems to be a Parser error when reading the file.
Error message "ERROR at setup of test_invalid_values_msu_feed"

Case 2:

Type Description
Test Path test_feeds/msu/test_invalid_values_msu_feed
Consistent yes
Test Execution 3/3 executions failed
Cases Fails 93
Summary On test_invalid_values_msu_feed when called check_feed_imported_successfully the problem could be a Parser error when check in the log or a problem when file is imported.
Error message "Could not find the message: 'Microsoft Security Update' feed finished successfully"

In order to finish this issue the following tasks should be fulfilled:

  • Research of fails.
  • Apply Fix
  • Full Green/ Full Yellow in test_feeds/msu/test_invalid_values_msu_feed for 3 times.
  • Documentation of any important change done for these tests or the used tools.
@damarisg damarisg changed the title Fix test_feeds/msu/test_invalid_values_msu_feed tests in 4.2 Fix test_feeds/msu/test_invalid_values_msu_feed tests in 4.2 Jul 6, 2021
@damarisg damarisg changed the title Fix test_feeds/msu/test_invalid_values_msu_feed tests in 4.2 Fix 'test_feeds/msu/test_invalid_values_msu_feed' tests in 4.2 Jul 6, 2021
@mdengra
Copy link
Contributor

mdengra commented Jul 15, 2021

2021-07-15

Test results with the modules sca, syscollector and rootcheck modules disabled in the ossec.conf:

Case 1

Test Executions Date By Status
test_invalid_values_msu_feed_local_dm_r1.log 2021-07-15 Miguel 🟢
test_invalid_values_msu_feed_local_dm_r2.log 2021-07-15 Miguel 🟢
test_invalid_values_msu_feed_local_dm_r3.log 2021-07-15 Miguel 🟢

Case 2

Test Executions Date By Status
test_invalid_values_msu_feed_local_dm_r1.log 2021-07-15 Miguel 🟢
test_invalid_values_msu_feed_local_dm_r2.log 2021-07-15 Miguel 🟢
test_invalid_values_msu_feed_local_dm_r3.log 2021-07-15 Miguel 🟢

@damarisg
Copy link
Member Author

This issue is closed by #1605

Test Results from 1531-full-yellow-vuln-det

Test Executions Date By Status
YellowResultsInvalidValuesMSUFeed.log 2021-07-21 Seyla 🟡
YellowResultsInvalidValuesMSUFeed2.log 2021-07-21 Seyla 🟢
YellowResultsInvalidValuesMSUFeed3.log 2021-07-21 Seyla 🟡
Reference Status
🟢 Pass without Warnings
🟡 Pass with Warnings

@damarisg damarisg self-assigned this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants