Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'test_feeds/msu/test_extra_fields_msu_feed' tests in 4.2 #1554

Closed
4 tasks
Tracked by #1531
damarisg opened this issue Jul 6, 2021 · 7 comments
Closed
4 tasks
Tracked by #1531

Fix 'test_feeds/msu/test_extra_fields_msu_feed' tests in 4.2 #1554

damarisg opened this issue Jul 6, 2021 · 7 comments

Comments

@damarisg
Copy link
Member

damarisg commented Jul 6, 2021

Issue information

Related issue
Closes #1531

When it comes to starting with the test fix, there is some information that can help you:

Module: Vulnerability Detector
Support Team:  "binary beasts"
Target: Manager   
OS: Linux

I add some information obtained while researched the logs that failed.

Case:

Type Description
Test Path test_feeds/msu/test_extra_fields_msu_feed
Consistent yes
Test Execution 3/3 executions failed
Cases Fails 48
Summary On check_feed_imported_successfully method the problem could be a Parser error when check in the log or a problem when file is imported.
Error message "Could not find the message: 'Microsoft Security Update' feed finished successfully"

In order to finish this issue the following tasks should be fulfilled:

  • Research of fails.
  • Apply Fix
  • Full Green/ Full Yellow in test_feeds/msu/test_extra_fields_msu_feed for 3 times.
  • Documentation of any important change done for these tests or the used tools.
@damarisg damarisg changed the title Fix test_feeds/msu/test_extra_fields_msu_feed tests in 4.2 Fix 'test_feeds/msu/test_extra_fields_msu_feed' tests in 4.2 Jul 6, 2021
@mdengra
Copy link
Contributor

mdengra commented Jul 13, 2021

2021-07-13

Similar to what happens in the issue #1553, when the sca module is disabled the test runs without problems, so probably the solution of the previous issue will be applicable in this one.

Test results after disabling the sca module:

Test Executions Date By Status
test_extra_fields_msu_feed_local_r1.log 2021-07-13 Miguel 🟢
test_extra_fields_msu_feed_local_r2.log 2021-07-13 Miguel 🟢
test_extra_fields_msu_feed_local_r3.log 2021-07-13 Miguel 🟢

@mdengra mdengra self-assigned this Jul 13, 2021
@pereyra-m
Copy link
Member

Results for test_feeds/msu/test_extra_fields_msu_feed.py

Test Executions Date By Status
centos_test_extra_fields_msu_feed_1.log 2021-07-13 Matias 🔴
centos_test_extra_fields_msu_feed_2.log 2021-07-13 Matias 🔴
centos_test_extra_fields_msu_feed_3.log 2021-07-13 Matias 🔴

@damarisg
Copy link
Member Author

damarisg commented Jul 14, 2021

This issue requires more research because when we execute it, we keep getting fails. We can see that this test is inconsistency.

Test Executions Date By Status
Results1_ExtraFieldMSUFeed.log 2021-07-13 Seyla 🔴
Results2_ExtraFieldMSUFeed.log 2021-07-13 Seyla 🔴
Results3_ExtraFieldMSUFeed.log 2021-07-13 Seyla 🔴

@mdengra
Copy link
Contributor

mdengra commented Jul 14, 2021

2021-07-14

I ran the tests again by recreating a new Vagrant box with a clean environment:

  • Local internal options:
    wazuh_modules.debug=2
    monitord.rotate_log=0
    
  • Modules disabled:
    rootcheck
    sca
    syscollector
    

Test results:

Test Executions Date By Status
test_extra_fields_msu_feed_local_r1.log 2021-07-14 Miguel 🟢
test_extra_fields_msu_feed_local_r2.log 2021-07-14 Miguel 🟢
test_extra_fields_msu_feed_local_r3.log 2021-07-14 Miguel 🟢

@pereyra-m
Copy link
Member

Results for test_feeds/msu/test_extra_fields_msu_feed.py
Now, the following modules were turned off: sca, syscollector and rootcheck

Test Executions Date By Status
test_extra_fields_msu_feed_modules_off_1.log 2021-07-14 Matias 🟢
test_extra_fields_msu_feed_modules_off_2.log 2021-07-14 Matias 🟢
test_extra_fields_msu_feed_modules_off_3.log 2021-07-14 Matias 🟢

@damarisg
Copy link
Member Author

Results when disabling modules: sca, syscollector and rootcheck.

Test Executions Date By Status
ExtraFieldMsu1.log 2021-07-14 Seyla 🟢
ExtraFieldMsu2.log 2021-07-14 Seyla 🟢
ExtraFieldMsu3.log 2021-07-14 Seyla 🟢

@damarisg
Copy link
Member Author

This issue is closed by #1605

Test Results from 1531-full-yellow-vuln-det

Test Executions Tests Date By Status
YellowResultsExtraFieldMSUFeed.log test_feeds/msu/test_extra_fields_msu_feed 2021-07-21 Seyla 🟡
YellowResultsExtraFieldMSUFeed2.log test_feeds/msu/test_extra_fields_msu_feed 2021-07-21 Seyla 🟡
YellowResultsExtraFieldMSUFeed3.log test_feeds/msu/test_extra_fields_msu_feed 2021-07-21 Seyla 🟡
Reference Status
🟡 Pass with Warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants