Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'test_general_settings/test_general_settings_enabled' tests in 4.2 #1556

Closed
4 tasks
Tracked by #1531
damarisg opened this issue Jul 6, 2021 · 3 comments
Closed
4 tasks
Tracked by #1531

Comments

@damarisg
Copy link
Member

damarisg commented Jul 6, 2021

Issue information

Related issue
Closes #1531

When it comes to starting with the test fix, there is some information that can help you:

Module: Vulnerability Detector
Support Team:  "binary beasts"
Target: Manager   
OS: Linux

I add some information obtained while researched the logs that failed.

Case:

Type Description
Test Path test_general_settings/test_general_settings_enabled
Consistent no
Test Execution 1/3 executions failed
Cases Fails 4
Summary It should to do research with more details because in the logs doesn't show any details.

In order to finish this issue the following tasks should be fulfilled:

  • Research of fails.
  • Apply Fix
  • Full Green/ Full Yellow in test_general_settings/test_general_settings_enabled for 3 times.
  • Documentation of any important change done for these tests or the used tools.
@damarisg damarisg changed the title Fix test_general_settings/test_general_settings_enabled tests in 4.2 Fix 'test_general_settings/test_general_settings_enabled' tests in 4.2 Jul 6, 2021
@pereyra-m
Copy link
Member

pereyra-m commented Jul 13, 2021

12/07

All the tests in the test_general_settings run successfully without any error locally (Ubuntu 20.04 and CentOS 8). The tests were run many times, even with different hardware configurations (4-2 cores, 2048-1024 MB).

These are the tests output for the Ubuntu Manager, a source installation of 4.2.0 was performed:

Test Executions Date By Status
ubuntu1.log 2021-07-12 Matias 🟢
ubuntu2.log 2021-07-12 Matias 🟢
ubuntu3.log 2021-07-12 Matias 🟢

These are the tests output for the CentOS Manager, a package installation was performed:

Test Executions Date By Status
centos.log 2021-07-12 Matias 🟢
centos2.log 2021-07-12 Matias 🟢
centos3.log 2021-07-12 Matias 🟢

Also, in Jenkins, any error was found after four attempts (package wazuh-manager-4.2.0-1.1493.x86_64.rpm, branch 1516-4.2.0-full-green):

Nevertheless, it is known that these tests are not completely reliable, so the root cause was investigated.
The FileMonitor component in the QA framework seems the most probable reason, because the tests are simple and just look for a specific line in the log.

Some manual tests were carried out to identify the cause of the slow file read.

Note

This analysis can be extended to the issues #1557 and #1558 because all of them are in the same test_general_settings folder.

@mdengra
Copy link
Contributor

mdengra commented Jul 13, 2021

@damarisg
Copy link
Member Author

This issue is closed, after executes for a lot of times and see that works.
We couldn't reproduce the error.

Test Executions Date By Status
test_general_settings_enabled_local_r1.log 2021-07-13 Miguel 🟢
test_general_settings_enabled_local_r2.log 2021-07-13 Miguel 🟢
test_general_settings_enabled_local_r3.log 2021-07-13 Miguel 🟢
Results1_EnableSetting.log 2021-07-13 Seyla 🟢
Results2_EnableSetting.log 2021-07-13 Seyla 🟢
Results3_EnableSetting.log 2021-07-13 Seyla 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants