Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'test_scan_results/test_inventory_feed' tests for debian, redhat and canonical in 4.2 #1566

Closed
6 tasks
damarisg opened this issue Jul 6, 2021 · 6 comments
Closed
6 tasks

Comments

@damarisg
Copy link
Member

damarisg commented Jul 6, 2021

Issue information

Related issue
Closes #1531

When it comes to starting with the test fix, there is some information that can help you:

Module: Vulnerability Detector
Support Team:  "binary beasts"
Target: Manager   
OS: Linux

I add some information obtained while researched the logs that failed.

In this case, We add 3 cases because the tests are similar and the error is the same. We believe that when solving one of the cases, the same fix could be applied to the other cases.

Case 1:

Type Description
Test Path test_scan_results/test_debian_inventory_debian_feed
Consistent yes
Test Execution 3/3 executions failed
Cases BUSTER
STRETCH
Cases Fails 2
Summary On test_debian_vulnerabilities_report when check_detected_vulnerabilities_number is called. it requires research to know if there is a problem with parser error or if we don't detect log.
Error message 'The expected number of OVAL vulnerabilities have not been found'

Case 2:

Type Description
Test Path test_scan_results/test_redhat_inventory_redhat_feed
Consistent yes
Test Execution 3/3 executions failed
Cases redhat_scan_configuration-RHEL5
redhat_scan_configuration-RHEL6
redhat_scan_configuration-RHEL7
redhat_scan_configuration-RHEL8
Cases Fails 4
Summary On test_redhat_vulnerabilities_report when check_detected_vulnerabilities_number is called. it requires research to know if there is a problem with parser error or if we don't detect log.
Error message "The expected number of {feed_source} vulnerabilities have not been found"

Case 3:

Type Description
Test Path test_scan_results/test_ubuntu_inventory_canonical_feed
Consistent yes
Test Execution 3/3 executions failed
Cases ubuntu_scan_configuration-FOCAL
ubuntu_scan_configuration-BIONIC
redhat_scan_configuration-XENIAL
redhat_scan_configuration-TRUSTY
Cases Fails 4
Summary On test_ubuntu_vulnerabilities_report when check_detected_vulnerabilities_number is called. it requires research to know if there is a problem with parser error or if we don't detect log.
Error message "The expected number of {feed_source} vulnerabilities have not been found"

In order to finish this issue the following tasks should be fulfilled:

  • Research of fails.
  • Apply Fix
  • Full Green/ Full Yellow in test_scan_results/test_debian_inventory_debian_feed for 3 times.
  • Full Green/ Full Yellow in test_scan_results/test_redhat_inventory_redhat_feed for 3 times.
  • Full Green/ Full Yellow in test_scan_results/test_ubuntu_inventory_canonical_feed for 3 times.
  • Documentation of any important change done for these tests or the used tools.
@damarisg damarisg changed the title Fix test_scan_results/test_inventory_feed tests for debian, redhat and canonicalin 4.2 Fix test_scan_results/test_inventory_feed tests for debian, redhat and canonical in 4.2 Jul 6, 2021
@damarisg damarisg changed the title Fix test_scan_results/test_inventory_feed tests for debian, redhat and canonical in 4.2 Fix 'test_scan_results/test_inventory_feed' tests for debian, redhat and canonical in 4.2 Jul 6, 2021
@pereyra-m pereyra-m self-assigned this Jul 14, 2021
@pereyra-m
Copy link
Member

These are the results for the different cases, all of them with sca, syscollector and rootcheck disabled

Case 1

Results for test_scan_results/test_debian_inventory_debian_feed.py

Test Executions Date By Status
test_debian_inventory_debian_feed_modules_off_1.log 2021-07-14 Matias 🟢
test_debian_inventory_debian_feed_modules_off_2.log 2021-07-14 Matias 🟢
test_debian_inventory_debian_feed_modules_off_3.log 2021-07-14 Matias 🟢

Case 2

Results for test_scan_results/test_redhat_inventory_redhat_feed.py

Test Executions Date By Status
test_redhat_inventory_redhat_feed_modules_off_1.log 2021-07-14 Matias 🟢
test_redhat_inventory_redhat_feed_modules_off_2.log 2021-07-14 Matias 🟢
test_redhat_inventory_redhat_feed_modules_off_3.log 2021-07-14 Matias 🟢

Case 3

Results for test_ubuntu_inventory_canonical_feed.py

Test Executions Date By Status
test_ubuntu_inventory_canonical_feed_modules_off_1.log 2021-07-14 Matias 🟢
test_ubuntu_inventory_canonical_feed_modules_off_2.log 2021-07-14 Matias 🟢
test_ubuntu_inventory_canonical_feed_modules_off_3.log 2021-07-14 Matias 🟢

@mdengra
Copy link
Contributor

mdengra commented Jul 15, 2021

2021-07-15

Test results with the modules sca, syscollector and rootcheck modules disabled in the ossec.conf:

Case 1

Test Executions Date By Status
test_debian_inventory_debian_feed_local_dm_r1.log 2021-07-15 Miguel 🟡
test_debian_inventory_debian_feed_local_dm_r2.log 2021-07-15 Miguel 🟡
test_debian_inventory_debian_feed_local_dm_r3.log 2021-07-15 Miguel 🟡

Case 2

Test Executions Date By Status
test_redhat_inventory_redhat_feed_local_dm_r1.log 2021-07-15 Miguel 🟡
test_redhat_inventory_redhat_feed_local_dm_r2.log 2021-07-15 Miguel 🟡
test_redhat_inventory_redhat_feed_local_dm_r3.log 2021-07-15 Miguel 🟡

Case 3

Test Executions Date By Status
test_ubuntu_inventory_canonical_feed_local_dm_r1.log 2021-07-15 Miguel 🟡
test_ubuntu_inventory_canonical_feed_local_dm_r2.log 2021-07-15 Miguel 🟡
test_ubuntu_inventory_canonical_feed_local_dm_r3.log 2021-07-15 Miguel 🟡

@damarisg
Copy link
Member Author

Test Results with the modules sca, syscollector and rootcheck modules disabled in the ossec.conf:

Case 1

Test Executions Date By Status
ScanDebian1.log 2021-07-15 Seyla 🟡
ScanDebian2.log 2021-07-15 Seyla 🟡
ScanDebian3.log 2021-07-15 Seyla 🟡

Case 2

Test Executions Date By Status
Results_ScanRedHat1.log 2021-07-15 Seyla 🟢
Results_ScanRedHat2.log 2021-07-15 Seyla 🟢
Results_ScanRedHat3.log 2021-07-15 Seyla 🟡

Case 3

Test Executions Date By Status
ResultsUbuntuInventoryCanonical1.log 2021-07-15 Seyla 🟡
ResultsUbuntuInventoryCanonical2.log 2021-07-15 Seyla 🟡
ResultsUbuntuInventoryCanonical3.log 2021-07-15 Seyla 🟡
Reference Status
🟢 Pass without warnings
🟡 Pass with Warnings

@damarisg
Copy link
Member Author

Test Results from 1531-full-yellow-vuln-det

Test Executions Tests Date By Status
YellowResultsScanDebianInventoryFeed.log test_scan_results/test_debian_inventory_debian_feed 2021-07-21 Seyla 🟡
YellowResultsScanDebianInventoryFeed2.log 2021-07-21 Seyla 🟡
YellowResultsScanDebianInventoryFeed3.log test_scan_results/test_debian_inventory_debian_feed 2021-07-21 Seyla 🟡
YellowResultsScanRedhatInventoryFeed1.log test_scan_results/test_redhat_inventory_redhat_feed 2021-07-21 Seyla 🟡
YellowResultsScanRedhatInventoryFeed2.log test_scan_results/test_redhat_inventory_redhat_feed 2021-07-21 Seyla 🟡
YellowResultsScanRedhatInventoryFeed3.log test_scan_results/test_redhat_inventory_redhat_feed 2021-07-21 Seyla 🟡
YellowResultsScanUbuntuInventoryFeed.log test_scan_results/test_ubuntu_inventory_canonical_feed 2021-07-21 Seyla 🟡
YellowResultsScanUbuntuInventoryFeed2.log test_scan_results/test_ubuntu_inventory_canonical_feed 2021-07-21 Seyla 🟡
YellowResultsScanUbuntuInventoryFeed3.log test_scan_results/test_ubuntu_inventory_canonical_feed 2021-07-21 Seyla 🟡
Reference Status
🟡 Pass with Warnings

Note

This issue fails sometimes by the bug wazuh/wazuh#9309

@mdengra
Copy link
Contributor

mdengra commented Jul 22, 2021

2021-07-22

Used Wazuh-QA branch: 1531-full-yellow-vuln-det
Test results with the default settings in the ossec.conf:

Case 1

Test Executions Date By Status
test_debian_inventory_debian_feed_local_r1.log 2021-07-22 Miguel 🟡
test_debian_inventory_debian_feed_local_r2.log 2021-07-22 Miguel 🟡
test_debian_inventory_debian_feed_local_r3.log 2021-07-22 Miguel 🟡

Case 2

Test Executions Date By Status
test_redhat_inventory_redhat_feed_local_r1.log 2021-07-22 Miguel 🟡
test_redhat_inventory_redhat_feed_local_r2.log 2021-07-22 Miguel 🟡
test_redhat_inventory_redhat_feed_local_r3.log 2021-07-22 Miguel 🟡

Case 3

Test Executions Date By Status
test_ubuntu_inventory_canonical_feed_local_r1.log 2021-07-22 Miguel 🟡
test_ubuntu_inventory_canonical_feed_local_r2.log 2021-07-22 Miguel 🟡
test_ubuntu_inventory_canonical_feed_local_r3.log 2021-07-22 Miguel 🟡

@damarisg
Copy link
Member Author

This issue is closed because the test was disabled by wazuh/wazuh#9309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants