Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong packages in some VD upgrade cases #5208

Closed
juliamagan opened this issue Apr 12, 2024 · 2 comments · Fixed by #5223
Closed

Wrong packages in some VD upgrade cases #5208

juliamagan opened this issue Apr 12, 2024 · 2 comments · Fixed by #5223
Assignees
Labels

Comments

@juliamagan
Copy link
Member

juliamagan commented Apr 12, 2024

Description

During the testing performed at wazuh/wazuh#22828 (comment), it was found that for Node.js versions 19.5.0 and 19.6.0, the .exe package is being installed on Windows instead of the -x64.msi package, as in the other cases.

"windows": {
"amd64": "https://nodejs.org/dist/v19.5.0/win-x86/node.exe"
}

"windows": {
"amd64": "https://nodejs.org/dist/v19.6.0/win-x86/node.exe"
}

In addition, the description of upgrade_package_nonvulnerable_to_nonvulnerable is not as expected, it should indicate version 19.6.0.

windows:
Used Package: Node 19.5.0 - Exe Format
"CVE": [],

On the other hand in macOS in the file test_vulnerability.yaml, in the case with id "id: upgrade_package_maintain_vulnerability" the version of the http-proxy package in the code of the "from" block must be changed from 0.5.10 to 0.5.9 because the version "0.5.10" is repeated both in the code of the "to" block and in the code of the "from" block:

from:
 macos:
  amd64: http-proxy-0.5.10
  arm64v8: http-proxy-0.5.10
to:
 macos:
  amd64: http-proxy-0.5.10
  arm64v8: http-proxy-0.5.10
@santipadilla santipadilla changed the title Wrong packages in some Windows upgrade cases Wrong packages in some VD upgrade cases Apr 12, 2024
@MARCOSD4 MARCOSD4 self-assigned this Apr 15, 2024
@MARCOSD4 MARCOSD4 linked a pull request Apr 16, 2024 that will close this issue
@MARCOSD4
Copy link
Member

Development Branch
bug/5208-change-packages-vd-test-cases

@davidjiglesias
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants