Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTT1 - The example dtt1-managers-poc-vagrant.yaml fails running the workflow with multiple threads #5240

Closed
mhamra opened this issue Apr 17, 2024 · 4 comments · Fixed by #5308
Assignees

Comments

@mhamra
Copy link
Member

mhamra commented Apr 17, 2024

Target version Related issue Related PR/dev branch
4.9.0 4995-dtt1-release

The workflow example file dtt1-managers-poc-vagrant.yaml fails when the workflow_engine is launched with multiple threads (--threads > 1).

The failure occurs because the provision run-manager-tests task doesn't depend on the allocation task. This task must run after all the allocation tasks have finished.

@rauldpm rauldpm added the level/task Task issue label Apr 18, 2024
@fcaffieri
Copy link
Member

This is not a bug, but rather the example versioned for the manager test is not correct. The problem is that the coined example does not have a depends-on that defines the execution criteria of the tasks. When executing 2 tasks with threads, both will be launched in parallel, and in the example it is required that the test task be executed no matter what after the allocation. Having said this, the issue is changed to a task since it is not a bug and the change, which is minimal, will be applied.

@rauldpm rauldpm changed the title DTT1-The example dtt1-managers-poc-vagrant.yaml fails running the workflow with multiple threads DTT1 - The example dtt1-managers-poc-vagrant.yaml fails running the workflow with multiple threads Apr 22, 2024
@mhamra mhamra linked a pull request Apr 29, 2024 that will close this issue
@rauldpm
Copy link
Member

rauldpm commented May 2, 2024

Moved ETA to 2/5/2024 due to pending review and missing changes

@pro-akim
Copy link
Member

pro-akim commented May 3, 2024

Review Notes

LGTM

@rauldpm
Copy link
Member

rauldpm commented May 3, 2024

LGTM

@rauldpm rauldpm closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants