Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries are stripped twice during installation from sources #13083

Closed
jnasselle opened this issue Apr 7, 2022 · 0 comments · Fixed by #13214
Closed

Binaries are stripped twice during installation from sources #13083

jnasselle opened this issue Apr 7, 2022 · 0 comments · Fixed by #13214
Assignees
Labels
module/building Compilation of the core product module/install Issue related to the installation process platform/linux platform/macos type/bug/non production Bug in a non-production branch

Comments

@jnasselle
Copy link
Member

Epic
#9913
Wazuh version Component Install type Install method Platform
dev-debug-symbols Makefile Manager/Agent Sources macOS/Linux

Description

Currently, the install.sh script is stripping again already stripped binaries, breaking some extracted debug symbol files. This can be seen by the sizes of the debug files.

Steps to reproduce

  1. Clone wazuh/wazuh repo and checkout to dev-debug-symbols branch
  2. Download deps and compile agent or server target
  3. List src/symbols files
  4. Install agent or server target
  5. List src/symbols files and /.symbols

Expected behavior

The listed files in steps 3 and 5 should be the same.

Current behavior

The listed files in steps 3 and 5 differ.
Step 3:

ll symbols
total 41M
-rwxr-xr-x 1 root root 803K Apr  6 12:40 agent-auth.debug
-rwxr-xr-x 1 root root  67K Apr  6 12:40 default-firewall-drop.debug
-rwxr-xr-x 1 root root  53K Apr  6 12:40 disable-account.debug
-rwxr-xr-x 1 root root  56K Apr  6 12:40 firewalld-drop.debug
-rwxr-xr-x 1 root root  62K Apr  6 12:40 host-deny.debug
-rwxr-xr-x 1 root root  51K Apr  6 12:40 ip-customblock.debug
-rwxr-xr-x 1 root root  53K Apr  6 12:40 ipfw.debug
-rwxr-xr-x 1 root root  50K Apr  6 12:40 kaspersky.debug
-rwxr-xr-x 1 root root 1.3M Apr  6 12:40 libdbsync.debug
-rwxr-xr-x 1 root root 675K Apr  6 12:40 librsync.debug
-rwxr-xr-x 1 root root 843K Apr  6 12:40 libsyscollector.debug
-rwxr-xr-x 1 root root 1.5M Apr  6 12:40 libsysinfo.debug
-rwxr-xr-x 1 root root  20M Apr  6 12:40 libwazuhext.debug
-rwxr-xr-x 1 root root 475K Apr  6 12:40 libwazuhshared.debug
-rwxr-xr-x 1 root root 836K Apr  6 12:40 manage_agents.debug
-rwxr-xr-x 1 root root  54K Apr  6 12:40 npf.debug
-rwxr-xr-x 1 root root  54K Apr  6 12:40 pf.debug
-rwxr-xr-x 1 root root  48K Apr  6 12:40 restart-wazuh.debug
-rwxr-xr-x 1 root root  49K Apr  6 12:40 route-null.debug
-rwxr-xr-x 1 root root 2.8M Apr  6 12:40 wazuh-agentd.debug
-rwxr-xr-x 1 root root 2.6M Apr  6 12:40 wazuh-execd.debug
-rwxr-xr-x 1 root root 2.9M Apr  6 12:40 wazuh-logcollector.debug
-rwxr-xr-x 1 root root 2.5M Apr  6 12:40 wazuh-modulesd.debug
-rwxr-xr-x 1 root root  58K Apr  6 12:40 wazuh-slack.debug
-rwxr-xr-x 1 root root 3.5M Apr  6 12:40 wazuh-syscheckd.debug

Step 5

total 17M
-rwxr-xr-x 1 root root 803K Apr  6 12:42 agent-auth.debug
-rwxr-xr-x 1 root root  67K Apr  6 12:42 default-firewall-drop.debug
-rwxr-xr-x 1 root root  53K Apr  6 12:42 disable-account.debug
-rwxr-xr-x 1 root root  56K Apr  6 12:42 firewalld-drop.debug
-rwxr-xr-x 1 root root  62K Apr  6 12:42 host-deny.debug
-rwxr-xr-x 1 root root  51K Apr  6 12:42 ip-customblock.debug
-rwxr-xr-x 1 root root  53K Apr  6 12:42 ipfw.debug
-rwxr-xr-x 1 root root  50K Apr  6 12:42 kaspersky.debug
-rwxr-xr-x 1 root root 3.5K Apr  6 12:42 libdbsync.debug
-rwxr-xr-x 1 root root 3.1K Apr  6 12:42 librsync.debug
-rwxr-xr-x 1 root root 3.0K Apr  6 12:42 libsyscollector.debug
-rwxr-xr-x 1 root root 3.5K Apr  6 12:42 libsysinfo.debug
-rwxr-xr-x 1 root root 2.9K Apr  6 12:42 libwazuhext.debug
-rwxr-xr-x 1 root root 475K Apr  6 12:42 libwazuhshared.debug
-rwxr-xr-x 1 root root 836K Apr  6 12:42 manage_agents.debug
-rwxr-xr-x 1 root root  54K Apr  6 12:42 npf.debug
-rwxr-xr-x 1 root root  54K Apr  6 12:42 pf.debug
-rwxr-xr-x 1 root root  48K Apr  6 12:42 restart-wazuh.debug
-rwxr-xr-x 1 root root  49K Apr  6 12:42 route-null.debug
-rwxr-xr-x 1 root root 2.8M Apr  6 12:42 wazuh-agentd.debug
-rwxr-xr-x 1 root root 2.6M Apr  6 12:42 wazuh-execd.debug
-rwxr-xr-x 1 root root 2.9M Apr  6 12:42 wazuh-logcollector.debug
-rwxr-xr-x 1 root root 2.5M Apr  6 12:42 wazuh-modulesd.debug
-rwxr-xr-x 1 root root  58K Apr  6 12:42 wazuh-slack.debug
-rwxr-xr-x 1 root root 3.5M Apr  6 12:42 wazuh-syscheckd.debug
@jnasselle jnasselle added platform/macos module/install Issue related to the installation process module/building Compilation of the core product type/bug/non production Bug in a non-production branch platform/linux labels Apr 7, 2022
@jnasselle jnasselle self-assigned this Apr 20, 2022
@jnasselle jnasselle linked a pull request Apr 22, 2022 that will close this issue
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/building Compilation of the core product module/install Issue related to the installation process platform/linux platform/macos type/bug/non production Bug in a non-production branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants