Default Syscollector scan interval not set #15428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dwordcito
force-pushed
the
dev-15413-default-syscollector-scan-interval-not-set
branch
from
85e9275
to
e5fb1f9
Compare
pereyra-m
previously approved these changes
Nov 22, 2022
2 tasks
|
jnasselle
previously approved these changes
Dec 2, 2022
| @@ -46,14 +46,15 @@ static void parse_synchronization_section(wm_sys_t * syscollector, XML_NODE node | |||
| } | |||
|
|
|||
| // Parse XML configuration | |||
| int wm_sys_read(const OS_XML *xml, XML_NODE node, wmodule *module) { | |||
| int wm_syscollector_read(const OS_XML *xml, XML_NODE node, wmodule *module) { | |||
Comment on lines
-99
to
+106
| syscollector->interval *= 86400; | ||
| syscollector->interval *= W_DAY_SECONDS; | ||
| break; | ||
| case 'h': | ||
| syscollector->interval *= 3600; | ||
| syscollector->interval *= W_HOUR_SECONDS; | ||
| break; | ||
| case 'm': | ||
| syscollector->interval *= 60; | ||
| syscollector->interval *= W_MINUTE_SECONDS; |
MiguelazoDS
dismissed stale reviews from jnasselle and pereyra-m
via
28cd479
Co-authored-by: Juan Nicolas Asselle <jnasselle@gmail.com>
Damian-Mangold
approved these changes
Dec 21, 2022
pereyra-m
approved these changes
Dec 27, 2022
Dwordcito
approved these changes
Dec 27, 2022
QA review
|
Dwordcito
deleted the
dev-15413-default-syscollector-scan-interval-not-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the scan time interval for Syscollector that was missing.
Configuration options
Section commented
Logs/Alerts example
Getting Syscollector configuration from API.
Syscollector scan is not triggered one after another in a few seconds.