Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review API endpoint responses inconsistencies #22990

Open
6 tasks
GGP1 opened this issue Apr 18, 2024 · 0 comments
Open
6 tasks

Review API endpoint responses inconsistencies #22990

GGP1 opened this issue Apr 18, 2024 · 0 comments
Labels
level/task type/bug Something isn't working

Comments

@GGP1
Copy link
Member

GGP1 commented Apr 18, 2024

Branch Component
20748-upgrade-to-connexion-3 RESTful API

Description

During #22478, we have found some inconsistencies in the responses of some endpoints. These were

  • GET /cluster/healthcheck uses "n/a" for unknown fields instead of "N/A" in uppercase like the rest. The information comes like this from the database, but to be consistent we should modify it to be consistent with the other responses.

  • The response of the endpoint GET /syscollector/:agent_id/packages has two fields location and install_time that are equal to " " on most items. The same happens in GET /syscollector/:agent_id/ports with process.

    This is because the database contains an empty space, we should consult with the core team to see if this is the desired behavior.

Checks

The following elements have been updated or reviewed (should also be checked if no modification is required):

  • Tests (unit tests, API integration tests).
  • Changelog.
  • Documentation.
  • Integration test mapping (using api/test/integration/mapping/_test_mapping.py).
@GGP1 GGP1 added type/bug Something isn't working level/task labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant