Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase AWS unit test coverage #23305

Open
3 tasks done
javiersanchz opened this issue May 6, 2024 · 1 comment · May be fixed by #23789
Open
3 tasks done

Increase AWS unit test coverage #23305

javiersanchz opened this issue May 6, 2024 · 1 comment · May be fixed by #23789
Assignees
Labels

Comments

@javiersanchz
Copy link
Member

javiersanchz commented May 6, 2024

Affected integration
AWS

Description

  • During the release of 4.8.0 - RC 1, the coverage percentages of the unit tests for the AWS module in s3_log_handler.py and sqs_message_processor.py are low, as can be seen at Release 4.8.0 - RC 1 - Python unit tests #23300 (comment). We should add test cases to increase it.

  • Another script to consider is wodles/utils.py with a percentage of 53%.

Checks

  • Unit tests without failures and related coverage reports.
  • Documentation.
  • Integration test mapping (using api/test/integration/mapping/_test_mapping.py).
@Selutario Selutario changed the title Add more aws unit test coverage Increase AWS unit test coverage May 6, 2024
@Selutario Selutario added type/bug Something isn't working and removed team/framework labels May 7, 2024
@GGP1 GGP1 self-assigned this May 30, 2024
@GGP1 GGP1 linked a pull request May 30, 2024 that will close this issue
@GGP1
Copy link
Member

GGP1 commented May 30, 2024

Update

The files mentioned have a 87% and 97% coverage as it can be checked in the latest pytest unit tests coverage report. I added unit tests for the utils.py file and removed some unused methods.

| wodles/aws/subscribers/s3_log_handler.py | 114 | 12 | 89% | :green_square: |
| wodles/aws/subscribers/sqs_message_processor.py | 35 | 1 | 97% | :green_square: |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Pending final review
Development

Successfully merging a pull request may close this issue.

3 participants