Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findings found after the analysis of the Wodles code #8347

Closed
3 tasks
Tracked by #2330
AdriiiPRodri opened this issue Apr 23, 2021 · 1 comment · Fixed by #10900
Closed
3 tasks
Tracked by #2330

Fix findings found after the analysis of the Wodles code #8347

AdriiiPRodri opened this issue Apr 23, 2021 · 1 comment · Fixed by #10900
Assignees
Labels
type/enhancement New feature or request

Comments

@AdriiiPRodri
Copy link
Contributor

AdriiiPRodri commented Apr 23, 2021

Wazuh version Component
master Wodles

Hi team,

In the wodles code there are some sections of code that can be improved.

First we have a part of the oscap.py module where an agent_id is calculated randomly. Basically it doesn't seem that the module ever enters this part, however, we should investigate it and either fix it or remove it.

The next thing we need to investigate is the use of the eval() functions and the subprocess module as they are being used to check that certain services are installed. This can be done in a better way.

More information here: #7998 (comment) and here: wazuh/wazuh-qa#1615 (comment)

ToDo

  • Investigate the random agent_id generator.
  • Replace eval and subprocess module.
  • Test the changes.

Regards

@CarlosRS9
Copy link
Contributor

Status update

It is true that the oscap module has these vulnerabilities. However, the module was deprecated in 4.0 and replaced by SCA, so we believe there is no reason to spend the time to modify this. The idea is to remove this code from our repository for the future 5.0 release.

The script itself from 4.0 onwards is no longer copied on the system during installation or when upgrading, so it would not pose a security risk either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants