Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unit tests for API python module #9914

Closed
davidjiglesias opened this issue Aug 26, 2021 · 1 comment
Closed

Add new unit tests for API python module #9914

davidjiglesias opened this issue Aug 26, 2021 · 1 comment
Assignees

Comments

@davidjiglesias
Copy link
Member

As we can observe in issue #9877 from the latest RC tests, the total coverage for the python modules is 76% for the Framework module, 19% for the API module and 24% for the Wodles module.

Since these tests are going to be passed in every PR and in every RC testing protocol, it is very important that we increase our code coverage to guarantee the proper behaviour of every module. Therefore, we should design and add new tests to increase the total coverage for the API module. The current coverage for the module can be seen in the table below.

API

Name Stmts Miss Cover Status
api/init.py 0 0 100% 🟩
api/alogging.py 43 3 93% 🟩
api/api_exception.py 11 0 100% 🟩
api/authentication.py 98 7 93% 🟩
api/configuration.py 85 4 95% 🟩
api/constants.py 10 0 100% 🟩
api/controllers/init.py 0 0 100% 🟩
api/controllers/active_response_controller.py 15 15 0% 🟥
api/controllers/agent_controller.py 221 221 0% 🟥
api/controllers/cdb_list_controller.py 40 40 0% 🟥
api/controllers/ciscat_controller.py 13 13 0% 🟥
api/controllers/cluster_controller.py 143 143 0% 🟥
api/controllers/decoder_controller.py 45 45 0% 🟥
api/controllers/default_controller.py 15 15 0% 🟥
api/controllers/experimental_controller.py 100 100 0% 🟥
api/controllers/manager_controller.py 96 96 0% 🟥
api/controllers/mitre_controller.py 13 13 0% 🟥
api/controllers/overview_controller.py 12 12 0% 🟥
api/controllers/rootcheck_controller.py 27 27 0% 🟥
api/controllers/rule_controller.py 57 57 0% 🟥
api/controllers/sca_controller.py 20 20 0% 🟥
api/controllers/security_controller.py 233 233 0% 🟥
api/controllers/syscheck_controller.py 31 31 0% 🟥
api/controllers/syscollector_controller.py 65 65 0% 🟥
api/controllers/task_controller.py 13 13 0% 🟥
api/controllers/vulnerability_controller.py 12 12 0% 🟥
api/encoder.py 24 24 0% 🟥
api/middlewares.py 101 101 0% 🟥
api/models/init.py 3 3 0% 🟥
api/models/active_response_model.py 36 36 0% 🟥
api/models/agent_added_model.py 29 29 0% 🟥
api/models/agent_inserted_model.py 48 48 0% 🟥
api/models/base_model_.py 104 104 0% 🟥
api/models/basic_info_model.py 59 59 0% 🟥
api/models/configuration_model.py 212 212 0% 🟥
api/models/group_added_model.py 15 15 0% 🟥
api/models/security_model.py 72 72 0% 🟥
api/models/security_token_response_model.py 19 19 0% 🟥
api/uri_parser.py 29 29 0% 🟥
api/util.py 108 10 91% 🟩
api/validator.py 145 10 93% 🟩
TOTAL 2422 1956 19% 🟥
@vicferpoy
Copy link
Contributor

Issue update

After closing all the related issues, coverage and testing quality has been highly increased.

Coverage Status
Before 19% 🟥
After 98% 🟩

API

Name Stmts Miss Cover Status
api/init.py 0 0 100% 🟩
api/alogging.py 43 3 93% 🟩
api/api_exception.py 11 0 100% 🟩
api/authentication.py 107 7 93% 🟩
api/configuration.py 85 4 95% 🟩
api/constants.py 10 0 100% 🟩
api/controllers/init.py 0 0 100% 🟩
api/controllers/active_response_controller.py 15 0 100% 🟩
api/controllers/agent_controller.py 228 0 100% 🟩
api/controllers/cdb_list_controller.py 40 0 100% 🟩
api/controllers/ciscat_controller.py 13 0 100% 🟩
api/controllers/cluster_controller.py 143 0 100% 🟩
api/controllers/decoder_controller.py 45 0 100% 🟩
api/controllers/default_controller.py 15 0 100% 🟩
api/controllers/experimental_controller.py 109 0 100% 🟩
api/controllers/manager_controller.py 96 0 100% 🟩
api/controllers/mitre_controller.py 41 0 100% 🟩
api/controllers/overview_controller.py 12 0 100% 🟩
api/controllers/rootcheck_controller.py 27 0 100% 🟩
api/controllers/rule_controller.py 57 0 100% 🟩
api/controllers/sca_controller.py 20 0 100% 🟩
api/controllers/security_controller.py 233 0 100% 🟩
api/controllers/syscheck_controller.py 31 0 100% 🟩
api/controllers/syscollector_controller.py 65 0 100% 🟩
api/controllers/task_controller.py 13 0 100% 🟩
api/controllers/vulnerability_controller.py 12 0 100% 🟩
api/encoder.py 24 1 96% 🟩
api/middlewares.py 102 35 66% 🟨
api/models/init.py 3 0 100% 🟩
api/models/active_response_model.py 36 0 100% 🟩
api/models/agent_added_model.py 29 0 100% 🟩
api/models/agent_inserted_model.py 48 0 100% 🟩
api/models/base_model_.py 104 0 100% 🟩
api/models/basic_info_model.py 59 0 100% 🟩
api/models/configuration_model.py 212 0 100% 🟩
api/models/group_added_model.py 15 0 100% 🟩
api/models/security_model.py 72 0 100% 🟩
api/models/security_token_response_model.py 19 0 100% 🟩
api/signals.py 2 2 0% 🟥
api/uri_parser.py 29 0 100% 🟩
api/util.py 108 4 96% 🟩
api/validator.py 145 10 93% 🟩
TOTAL 2478 66 98% 🟩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants