fix(fitview): handle child nodes closes #2223

xyflow · Jun 21, 2022 · dbd527a · dbd527a
1 parent dba65f8
commit dbd527a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/example/src/Subflow/index.tsx b/example/src/Subflow/index.tsx
@@ -39,16 +39,15 @@ const initialNodes: Node[] = [
   {
     id: '4b',
     data: { label: 'Node 4b' },
-    position: { x: 150, y: 50 },
+    position: { x: 100, y: 60 },
     className: 'light',
     style: { backgroundColor: 'rgba(50, 50, 255, 0.5)', height: 200, width: 300 },
     parentNode: '4',
-    expandParent: true,
   },
   {
     id: '4b1',
     data: { label: 'Node 4b1' },
-    position: { x: 20, y: 20 },
+    position: { x: 40, y: 20 },
     className: 'light',
     parentNode: '4b',
   },

diff --git a/src/store/utils.ts b/src/store/utils.ts
@@ -105,7 +105,7 @@ export function fitView(get: GetState<ReactFlowState>, options: InternalFitViewO
   if ((options.initial && !fitViewOnInitDone && fitViewOnInit) || !options.initial) {
     if (d3Zoom && d3Selection) {
       const nodes = Array.from(nodeInternals.values()).filter((n) =>
-        options.includeHiddenNodes ? !n.parentNode && n.width && n.height : !n.parentNode && !n.hidden
+        options.includeHiddenNodes ? n.width && n.height : !n.hidden
       );
 
       const nodesInitialized = nodes.every((n) => n.width && n.height);