Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panOnScroll direction is opposite direction of expected behaviour #683

Closed
o0x2a opened this issue Nov 13, 2020 · 4 comments · Fixed by #676
Closed

panOnScroll direction is opposite direction of expected behaviour #683

o0x2a opened this issue Nov 13, 2020 · 4 comments · Fixed by #676

Comments

@o0x2a
Copy link

o0x2a commented Nov 13, 2020

I'm using mac and the scrolling/panning using trackpad in react-flow I experience opposite direction of what I experience in other apps and or when scrolling a web page. I'm not sure if this behaviour is by design or not. However as a user, I expect the same scrolling behaviour as I scroll down a webpage, it would be much less confusing.

Thanks :-)

@moklick
Copy link
Member

moklick commented Nov 14, 2020

Hey @Code-guru

which version are you using? Could you tryreact-flow-renderer@next

@o0x2a
Copy link
Author

o0x2a commented Nov 16, 2020

I was using 7.1.2, but tried 8.0.0-next.6, and the scrolling behaviour is the same. Here is example with pan on scroll enabled https://codesandbox.io/s/fragrant-monad-w4m40?file=/src/Overview/index.js

If you compare the graph and code editor, I expect the content flow in the same direction using the same scroll gesture. When scroll gesture in the code editor shows the code below, the same scroll gesture on the graph also should displays the digram below. As a reference we can compare pan on scroll with draw.io https://app.diagrams.net/

Maybe the developer wanted to have mac scroll behaviour on windows, or vice versa, but it should only the follow the system scrolling behaviour. I mean scrolling the react flow graph should be similar as scrolling a text document or webpage.

@chrtze
Copy link
Member

chrtze commented Nov 16, 2020

thanks @Code-guru, we have taken a second look on the behaviour and it was confusing for us as well. we want to have the same logic as draw.io, sketch, etc. this should now be fixed and released in the next version.

@chrtze chrtze closed this as completed Nov 16, 2020
@chrtze chrtze linked a pull request Nov 16, 2020 that will close this issue
@o0x2a
Copy link
Author

o0x2a commented Nov 16, 2020

awesome, many thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants