🐛 Fixes a bug where 'handleNodeClick' could runtime error if the node had already been removed. #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et node had already been removed.
|
See xyflow/react-flow-docs#131 for the companion docs update. |
moklick
requested changes
Aug 7, 2023
packages/core/src/contants.ts
Outdated
| @@ -17,4 +17,6 @@ export const errorMessages = { | |||
| }", edge id: ${edge.id}.`, | |||
| error010: () => 'Handle: No node id found. Make sure to only use a Handle inside a custom Node.', | |||
| error011: (edgeType: string) => `Edge type "${edgeType}" not found. Using fallback type "default".`, | |||
| error012: (id: string) => | |||
| `Node with id "${id}" does not exist, it may have been removed. This can happen when a node is deleted before the "onNodeClick" handler is called. If this wasn't on purpose, please defer deleting this node until the "onNodeClick" handler is called by using "requestAnimationFrame" or "setTimeout".`, | |||
There was a problem hiding this comment.
"Node with id "${id}" does not exist, it may have been removed." - this is enough for the error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
handleNodeClickno-ops if the target node doesn't exist.`Node with id "${id}" does not exist, it may have been removed. This can happen when a node is deleted before the "onNodeClick" handler is called. If this wasn't on purpose, please defer deleting this node until the "onNodeClick" handler is called by using "requestAnimationFrame" or "setTimeout".`This can come up if a custom node has a delete button, for example, and the user also has a
onNodeClickhandler set up on the<ReactFlow>component.