Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use completing-read-multiple for multiple files selection #72

Closed
meliache opened this issue Apr 16, 2024 · 1 comment
Closed

Use completing-read-multiple for multiple files selection #72

meliache opened this issue Apr 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@meliache
Copy link

I would prefer if the package used completing-read-multiple in python-pytest--select-test-files rather than just completing-read in a while loop with an extra candidate to finish completion. In python-pytest--select-test-files, the final part of the function body could be simplified to (completing-read-multiple "Choose test files: " candidates). The user can then just use normal interactive completion to select a file and if they want to select multiple files, they just enter a comma or whatever their value of crm-separator is. The advantage is that it requires less user inputs if the user just wants to select a single file or diretory and you don't need to rely on the user finding the special "finish completion" candidate.

@meliache meliache changed the title Use completing-read-multiple for multiple files selection rather Use completing-read-multiple for multiple files selection Apr 16, 2024
@wbolster wbolster self-assigned this Apr 16, 2024
@wbolster wbolster added the enhancement New feature or request label Apr 16, 2024
@wbolster
Copy link
Owner

yeah, makes total sense, guess i wasn't aware of that when i built the convoluted logic before. fixed via f945da6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants