Update to Thrift v0.9.0 and added a README.TXT file. #27

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@rogerhu
Contributor
rogerhu commented Jun 4, 2013

Use a symlink for the hbase/ directory to help denote the version being used.

@wbolster
Owner
wbolster commented Jun 4, 2013

Wow, I was just looking into compiling Thrift when I saw this request. Thanks. :)

Are these the unchanged files generated by Thrift?

@wbolster
Owner
wbolster commented Jun 4, 2013

Follow-up question: which HBase version does the .thrift file belong to?

@rogerhu
Contributor
rogerhu commented Jun 4, 2013

Yes it's unchanged :) I did use the py:new_style option so they actually use new classes.

I'll version the .thrift version too to make it more clear. :)

@wbolster
Owner
wbolster commented Jun 4, 2013

I'm not sure about the symlink approach. It might confuse packaging tools. I'd rather have an explicit README stating the exact versions.

@rogerhu
Contributor
rogerhu commented Jun 4, 2013

I left the Hbase.thrift file alone since it appears that the latest 0.98.4 has some additional IDL definitions.

Updated the README.TXT file inside hbase/.

@rogerhu rogerhu commented on the diff Jun 4, 2013
happybase/hbase/README.TXT
+======
+
+These Thrift/HBase bindings were generated with the Hbase.thrift version that can be downloaded from:
+
+http://www.apache.org/dyn/closer.cgi/hbase/
+
+The thrift bindings can be generated by downloading the Thrift version at:
+
+http://thrift.apache.org/
+
+The bindings were generated with this command:
+
+```bash
+thrift --gen py:new_style Hbase.thrift
+```
+Thrift version used: 0.9.0
@rogerhu
rogerhu Jun 4, 2013 Contributor

Not sure which HBase version is being used. It looks like 0.98.4 at http://apache.petsads.us/hbase/stable/ has a different IDL, but not ready to upgrade yet.. :)

@wbolster
Owner
wbolster commented Jun 4, 2013

Okay, I've merged (actually, rebased and slightly adapted) your changes into master branch:

@wbolster wbolster closed this Jun 4, 2013
@wbolster
Owner
wbolster commented Jun 4, 2013

I'm resolving this issue now. Thanks for your contribution!

@rogerhu
Contributor
rogerhu commented Jun 4, 2013

Thanks for your fast response and support of this library!

On Tue, Jun 4, 2013 at 2:05 PM, Wouter Bolsterlee
notifications@github.comwrote:

I'm resolving this issue now. Thanks for your contribution!


Reply to this email directly or view it on GitHubhttps://github.com/wbolster/happybase/pull/27#issuecomment-18939112
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment