Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Thrift v0.9.0 and added a README.TXT file. #27

Closed
wants to merge 2 commits into from

Conversation

rogerhu
Copy link
Contributor

@rogerhu rogerhu commented Jun 4, 2013

Use a symlink for the hbase/ directory to help denote the version being used.

@wbolster
Copy link
Member

wbolster commented Jun 4, 2013

Wow, I was just looking into compiling Thrift when I saw this request. Thanks. :)

Are these the unchanged files generated by Thrift?

@wbolster
Copy link
Member

wbolster commented Jun 4, 2013

Follow-up question: which HBase version does the .thrift file belong to?

@rogerhu
Copy link
Contributor Author

rogerhu commented Jun 4, 2013

Yes it's unchanged :) I did use the py:new_style option so they actually use new classes.

I'll version the .thrift version too to make it more clear. :)

@wbolster
Copy link
Member

wbolster commented Jun 4, 2013

I'm not sure about the symlink approach. It might confuse packaging tools. I'd rather have an explicit README stating the exact versions.

@rogerhu
Copy link
Contributor Author

rogerhu commented Jun 4, 2013

I left the Hbase.thrift file alone since it appears that the latest 0.98.4 has some additional IDL definitions.

Updated the README.TXT file inside hbase/.

```bash
thrift --gen py:new_style Hbase.thrift
```
Thrift version used: 0.9.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which HBase version is being used. It looks like 0.98.4 at http://apache.petsads.us/hbase/stable/ has a different IDL, but not ready to upgrade yet.. :)

@wbolster
Copy link
Member

wbolster commented Jun 4, 2013

Okay, I've merged (actually, rebased and slightly adapted) your changes into master branch:

@wbolster wbolster closed this Jun 4, 2013
@wbolster
Copy link
Member

wbolster commented Jun 4, 2013

I'm resolving this issue now. Thanks for your contribution!

@rogerhu
Copy link
Contributor Author

rogerhu commented Jun 4, 2013

Thanks for your fast response and support of this library!

On Tue, Jun 4, 2013 at 2:05 PM, Wouter Bolsterlee
notifications@github.comwrote:

I'm resolving this issue now. Thanks for your contribution!


Reply to this email directly or view it on GitHubhttps://github.com//pull/27#issuecomment-18939112
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants