Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing urllib2 with Requests library for downloading #139

Closed
wants to merge 4 commits into from
Closed

Replacing urllib2 with Requests library for downloading #139

wants to merge 4 commits into from

Conversation

schlamar
Copy link
Contributor

@schlamar schlamar commented Jun 1, 2012

This will fix

and probably every other SSL/Proxy/Download problem currently issued.

It is about 10 times faster than the former downloader (subjective opinion). Furthermore, this will clean up your code base, the urllib2 download code was really messy.

More info about Requests: http://docs.python-requests.org

@schlamar schlamar mentioned this pull request Jun 1, 2012
@schlamar
Copy link
Contributor Author

schlamar commented Jun 6, 2012

You should not merge this until this issue is solved: https://github.com/kennethreitz/requests/issues/655

@foamdino
Copy link

foamdino commented Jul 3, 2012

Upvote for using requests - a sane solution to connecting to webservices.

@schlamar
Copy link
Contributor Author

schlamar commented Jul 3, 2012

@foamdino This is no good idea as long as requests does not support SSL via proxies (see the link above).

@wbond
Copy link
Owner

wbond commented Nov 10, 2012

I am aware that the urllib2 code is really messy (and has gotten moreso recently due to needing to monkeypatch some core python stuff), but I believe it is finally at a point where it properly:

  1. Works with proxy auth for HTTPS urls
  2. Supports NTLM auth for HTTP and HTTPS proxies
  3. Properly validates SSL certificates.

Any proposal to replace the urllib2 stuff will need to handle those. Feel free to re-open this if it does all of those.

@wbond wbond closed this Nov 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants