Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If multiple "ratings on pages", only first displays #2

Closed
gcameo opened this issue Oct 23, 2010 · 2 comments
Closed

If multiple "ratings on pages", only first displays #2

gcameo opened this issue Oct 23, 2010 · 2 comments

Comments

@gcameo
Copy link

gcameo commented Oct 23, 2010

Realised that if there are multiple ratings on a page, and you are using start value of double eg 3.3 instead of integer, only the first rating component dsiplays. the remaining components are not displayed.

A little debugging showed this line to be the culprit

hint = (options.number <= options.hintList.length && options.hintList[start - 1] !== null) ? options.hintList[start - 1] : start;

Line number 198 in version 0.6 release.

Commenting out that and providing dummy hints fixed the issue but obviously, the hints on the displayed widget were wrong
Commenting out that and providing some dummy hints f

@wbotelhos
Copy link
Owner

Fixed by: http://github.com/wbotelhos/raty/commit/9a88264236848d481999f0b0f8861ccabad77834

If it's ok, then close the issue for me please.
Thank you. (:

@gcameo
Copy link
Author

gcameo commented Oct 28, 2010

yes, its now Ok. Thanks

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants