Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scroll position of open document tab bar changes on engrave #716

Closed
PaulMorris opened this issue Jul 14, 2015 · 6 comments
Closed

Comments

@PaulMorris
Copy link

When you have a lot of documents open so that they overflow the width of the horizontal "tab bar" where the titles of all the open documents appear, and the left and right arrows appear that let you scroll left and right... And then you engrave one of the documents... The horizontal scrolling position of the tab bar changes, so that different document tabs are visible, and you have to manually click the arrows to move it back where you want it, every time you engrave a document.

It would be better if the horizontal "scroll position" stayed the same when you engrave a document, so that the same documents stayed in view, before and after engraving.

@uliska
Copy link
Collaborator

uliska commented Jul 14, 2015

Does this depend on the "Engrave this document" setting?

@PaulMorris PaulMorris changed the title Open document tab bar scroll position changes on engrave Horizontal scroll position of open document tab bar changes on engrave Jul 14, 2015
@PaulMorris
Copy link
Author

Do you mean LilyPond menu --> "Always engrave this document" ?
That setting doesn't affect it.

@uliska
Copy link
Collaborator

uliska commented Jul 14, 2015 via email

@PaulMorris
Copy link
Author

More details: It seems that on engrave it always returns the scroll position all the way to the left, unless that would cause the engraved document to go out of view, so in that case it moves the scroll position to the left until the engraved document is all the way at the right side of the visible tabs (which pushes any tabs to its right out of view).

@PaulMorris
Copy link
Author

So if the digits are open tabs and the [ ] indicates the currently visible tabs:
1 2 3 4 [5 6 7 8] 9

And I engrave tab 5, then this is the new scroll position:
1 [2 3 4 5] 6 7 8 9

@wbsoft
Copy link
Collaborator

wbsoft commented Dec 25, 2015

Yes this is annoying, but caused by QTabBar. An engrave job causes the icon of a document to change, and this icon change triggers a redraw of the tab bar, which QTabBar does not handle nicely, especially when the tab whose icon changes was not completely visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants