Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/refactor slots and other methods #747

Closed
uliska opened this issue Jul 28, 2015 · 3 comments
Closed

Review/refactor slots and other methods #747

uliska opened this issue Jul 28, 2015 · 3 comments
Assignees

Comments

@uliska
Copy link
Collaborator

uliska commented Jul 28, 2015

It seems that many things are not at their proper place yet. While this doesn't affect the functionality I would prefer making the architecture right before the initial release as much as possible.

To be considered are the questions

  • What action/slot/method belongs to Panel/Widget/View?
  • What belongs to the base class and what to the child class?

I have already done a few things but held them back due to the massive working on the session handling. So I will start by re-applying these things and then have a look.

@uliska uliska self-assigned this Jul 28, 2015
@uliska uliska added this to the Initial Manuscript Viewer milestone Jul 28, 2015
@uliska
Copy link
Collaborator Author

uliska commented Jul 29, 2015

I think I'm through with the panel and the widget classes. What remains to be done (now or later) is the whole DocumentChooserAction complex. But maybe this one has to be reconsidered anyway.

@uliska
Copy link
Collaborator Author

uliska commented Aug 3, 2015

I have now (as of c474727) moved everything from the manuscript viewer's document chooser action to the base class.
.

@uliska
Copy link
Collaborator Author

uliska commented Aug 3, 2015

@PeterBjuhr I think this can be closed now

@uliska uliska closed this as completed Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant