Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git submodules support #99

Open
wbthomason opened this issue Nov 23, 2020 · 2 comments
Open

Add git submodules support #99

wbthomason opened this issue Nov 23, 2020 · 2 comments

Comments

@wbthomason
Copy link
Owner

No description provided.

@matu3ba
Copy link
Contributor

matu3ba commented Oct 6, 2021

git submodules might break your simple method of deduplication.
packer supports 1. git repos, 2. luarocks (which in turn supports arbitrary installments and compiling of projects like luaformatter).
Also I dont see how plugins cant vendor their own makefiles to fetch dependencies, if necessary.

Also YAGNI if no concrete use case(s) exist(s).

@wbthomason
Copy link
Owner Author

Plugins can vendor their own makefiles; submodules would cover a common use case for this and eliminate the need to manually specify e.g. run = 'make' for plugins which take this approach. It shouldn't interact with deduplication - plugins would be expected to structure their submodules such that any submodule dependencies are isolated and do not cause duplicate collisions (e.g. no adding submodules on a runtime sourced path).

re: YAGNI: Well, there's a reason I made this feature note almost a year ago and haven't prioritized implementing it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants