Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with socket.io 1.0.6 ? #40

Closed
tomahim opened this issue Jun 20, 2014 · 4 comments
Closed

Compatibility with socket.io 1.0.6 ? #40

tomahim opened this issue Jun 20, 2014 · 4 comments

Comments

@tomahim
Copy link

tomahim commented Jun 20, 2014

Hello,

Since socket.io released a 1.0.6 version, do session.socket.io is compatible with this new version ? I need to migrate to this version and my previous code which contain
socket.handshake.getSession method is saying me that socket.handshake has no getSession method.

Is there a workaround or maybe the compatibility with socket.io 1.0.6 is plan soon ?

Thank you

@wcamarao
Copy link
Owner

Hi tomahim, do you want to send a PR making it compatible with the new version of socket.io? I'd be fine about merging that. There's also plans of doing the same for express 4.

@tomahim
Copy link
Author

tomahim commented Jun 23, 2014

Hi wcamarao,

I don't really have the time to send you a PR, but I managed to find a workaround, I don't know if it's a good solution but using : socket.conn.request.getSession instead of socket.handshake.getSession seems to work perfectly without any changes to session.socket.io

@JohnMcLear
Copy link

@tomahim your replacement solution worked great for me, this should be in the socketIO V1+ migration guide imho bump @guille

@wcamarao
Copy link
Owner

I've added support for express 4 which was tested with socket.io 1.3.5. It's now published on npm.

Please reopen if you still have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants