Allow passing arbitrary props to ReText component #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, could the same be achieve with |
|
I used a separate prop since I wanted to avoid people setting "value" prop via this. But now that I read it it's still possible to do that. I guess changing it to be If that works I'll make the change and then will verify it in my app too. |
|
yes that sounds awesome |
Jyrno42
changed the title
textInputProps to ReText component to allow passing arbitrary props to it
Jyrno42
force-pushed
the
retext-add-text-input-props
branch
from
54be057
to
3b8f97f
Compare
|
It's updated now and worked in my app too. |
|
so good thks! |
|
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #500