Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The category dropdown doesn't reflect the actual selection state #20

Closed
d33t opened this issue Oct 18, 2023 · 5 comments · Fixed by #21
Closed

The category dropdown doesn't reflect the actual selection state #20

d33t opened this issue Oct 18, 2023 · 5 comments · Fixed by #21

Comments

@d33t
Copy link

d33t commented Oct 18, 2023

The "category" dropdown doesn't get updated on page load and on selection and thus doesn't reflect the actual selection state and shows always “all” even if other option is selected. After a page refresh, the last chosen value gets internally selected, the dropdown still shows "all", but the values displayed are for the previously selected category.

To summarize:

  1. The filter "category" will always show “all” and never the actual selected category.
  2. The previous selected value is stored on client side and when the page is refreshed may lead to confusions where the user see “all” selected but not the expected results for this category.
@stefanseifert
Copy link
Member

thanks for the report. this sounds like a bug, i will have a look at it (in november)

@stefanseifert
Copy link
Member

i can confirm the problem on AEM 6.5.18, but it works fine on AEMaaCS SDK.

@d33t
Copy link
Author

d33t commented Nov 9, 2023

Thanks for taking a look and confirming. It sounds like you have a fix for it already possibly present on the AEMaaCS branch (even if I don't see it)? Or is it the same code that just behaves differently on AEMaaCS?

@stefanseifert
Copy link
Member

the previous code already worked fine in AEMaaCS SDK.
#21 refactors the code in a way that should work both on AEM 6.5 and AEMaaCS - can you give it a try?

@d33t
Copy link
Author

d33t commented Nov 9, 2023

I can confirm that your fix works on AEM 6.5.17. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants