Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix returning from Publication wizards in AEMaaCS with Unified Shell #23

Merged
merged 13 commits into from Nov 21, 2023
Merged

Fix returning from Publication wizards in AEMaaCS with Unified Shell #23

merged 13 commits into from Nov 21, 2023

Conversation

stefanseifert
Copy link
Member

@stefanseifert stefanseifert commented Nov 20, 2023 •
edited

  • Integrate component unifiedshell/components/unifiedshell in the editor page to enable the unified shell (if available and enabled)
  • Refactor Coral UI Shell markup a bit to fit with header show/hide based on shell enablement
  • Detect non-existence of Unified Shell (on AEM 6.5) and make sure no errors/warnings are logged in that case
  • Eliminate compile errors of Clientlib on AEM 6.5

Fixes #22

@stefanseifert stefanseifert mentioned this pull request Nov 20, 2023
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@stefanseifert stefanseifert merged commit 29afd5e into develop Nov 21, 2023
8 checks passed
@stefanseifert stefanseifert deleted the feature/unifiedshell-publishwizard branch November 21, 2023 08:55
@stefanseifert stefanseifert mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We are seeing Quick Publish Wizard to reload constantly after any change in ca config - AEMaaCS
1 participant
@stefanseifert