Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api v0.13.0 #45

Open
blumamir opened this issue Dec 13, 2020 · 1 comment
Open

api v0.13.0 #45

blumamir opened this issue Dec 13, 2020 · 1 comment

Comments

@blumamir
Copy link
Contributor

In know this plugin is in the process of migrating to the contrib repo, but I'll ask here since I'm not sure when it will be available there.

This plugin is currently using dependency

    "@opentelemetry/api": "^0.6.0",
    "@opentelemetry/core": "^0.6.0"

Which are quite old (released on Apr 2).
It looks like v0.13.0 had breaking changes which broke the async context propagation somehow. This line no longer works in v0.13.0.
It's kind of strange, as the plugin should install it's own version of the api / tracing packages to node_modules, but somehow it doesn't work after upgrading from v0.12.0 to v0.13.0.

In additional, the Span status code has changed in a non-backward compatible way, which means plugins using api version of <0.12.0 will use the old GRPC CanonicalCode enum and thus report wrong value with exporter Collector.

Was wondering what your plans are for supporting v0.13.0.
I can create a PR here to fix the issues if you like and willing to review and publish new plugin verison. Or do you plan to do further releases from the contrib repo? (the review-publish cycle there can take many many weeks in my experience).
We are blocked on this issue currently and not able to upgrade to otel latest.

@blumamir
Copy link
Contributor Author

Investigated the issue. The plugin has no dependency on @opentelemetry/tracing, thus when calling startSpan, the function is called on the package installed in node_modules (and not on v0.6.0 which is the version of @opentelemetry/api in package.json).
In v0.13.0 the function signature changed, and the plugin needs to be changed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant