Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer escape parsing if next char is not in the current chunk #86

Closed
wants to merge 1 commit into from
Closed

Defer escape parsing if next char is not in the current chunk #86

wants to merge 1 commit into from

Conversation

adrianheine
Copy link

If the last char of a chunk is the escape char, parsing fails.

@wdavidw
Copy link
Member

wdavidw commented Mar 19, 2013

I andrian, thank you for reporting this issue with a patch. I need a testcase illustrating the fix, could you provide me with one?

@adrianheine
Copy link
Author

wdavidw added a commit that referenced this pull request Apr 10, 2013
@wdavidw
Copy link
Member

wdavidw commented Apr 10, 2013

This is fixed, I didn't use your pull request but instead I leverage a mechanism alraedy present inside the parser. Thanks again, I'll publish a new npm version today.

@wdavidw wdavidw closed this Apr 10, 2013
@adrianheine
Copy link
Author

Thanks. My pull request refers to v0.1, though, so your fix doesn't work for me. I'll probably just switch over to master, but if you want to support 0.1.x, you should probably backport the fix.

@wdavidw
Copy link
Member

wdavidw commented Apr 10, 2013

I don't think many users are still with v0.1, so unless you tell me it will be helpfull for you to backport this fix into an npm release, i will just pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants