New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7 Compatibility #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will release version 1.1 containing this update sometime next week.
Thanks a lot for your contribution!
Hi @donovanhare, Starting with version 1.1 I will switch away from the MIT license and make Nova Calendar available under the following dual licensing model:
Do you agree to your pull request being included and distributed under this dual licensing model? I'd be happy to answer any questions or comments you might have. |
Yes, that sounds like a great direction forward. Thank you for checking in with me 👍 |
Great, I will merge and release the update as soon as possible :). |
I have the merge ready, but need a bit more time to release it -- since the namespace of the dataprovider changes, releasing this update will break backwards compatibility and force me to do a major version bump to 2.0 in order to follow semantic versioning and not break existing installations unexpectedly. I want to make use of that major version bump in order to do some more changes that might break backwards compatibility so I will delay the release of PHP7 support a bit in order to do a nice 2.0 release. Sorry for the delay; if anyone is eager to run this package under PHP7 already, take a look at the changes in the commits of this pull request and feel free to ask for help in a Discussion. |
Merged into |
Finally out with the release of 2.0 today :) Thanks again, @donovanhare ! |
Amazing, thank you @wdelfuego :) |
Needed to use this package with PHP 7, so have made the nessersary adjustments to make it backwards compatible.
Let me know if you need me to do anything else.