-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push auras from Wago to Companion #44
Comments
Just one more for the "we need tags" category, I think. |
I have implemented it on companion without much thinking on the UI part it adds a table to WeakAurasCompanion global variable in game
When game is reloaded, file is rewrite with an empty WeakAurasCompanion.stash |
Considering that:
@Stanzilla @emptyrivers @InfusOnWoW do you have ideas or preferences on how to show each import button in weakauras ? some options that may be doable :
Stan on discord though about importing the auras directly and use the future tag system to categorize them. |
I think the best way would be a new button somewhere that shows there are new auras available to import from wago, that shows a new pop up window |
I like the idea of adding an option to the weakaurasOptions panel in addition to a chat reminder on login. I'm not sure of the point of auto wiping the stash table on reload though. Would it not be better to detect if an import from the stash is imported (or deleted/cancelled) from in game, and then removing it? Also I agree that there should be some user interaction in-game, much like when an update is available. |
The implementation of this local webserver is, quite frankly, begging for a cross-site request forgery attack.
I agree, but this is a bit like the pot calling the kettle black :) |
Besides that though... Relying on a chat message on login is foolishness, in my opinion. It's probably fine to have a message in the login, but there are too many other addons which also fill the chat message history. That leaves us with essentially three options:
|
…config-prettier-3.4.0 Bump eslint-config-prettier from 3.3.0 to 3.4.0
Another request which might just fit this topic: |
There are countless of free tools for syncing files between computers |
From @oratory on 20 december
We got to think about the workflow after pushing that button on Wago.
Wago
Push "Send to WeakAuras Companion App"
Companion
I'm thinking about making the app go into a "stash mode" that let you push more auras
Every time you push another aura it goes in the stash, which reflect what is stored for weakauras
Next time WoW (re)load it show stashed auras
When app detect World of Warcraft has finish showing a load screen, it gets out of stash mode and reset the data
WeakAuras
On load, check if there are auras in Companion's stash
Then how to let user interact with the data is yet to decide, some options are:
The text was updated successfully, but these errors were encountered: