Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stale / consistent queries #110

Closed
jhmartin opened this issue Nov 11, 2016 · 7 comments
Closed

Support stale / consistent queries #110

jhmartin opened this issue Nov 11, 2016 · 7 comments
Milestone

Comments

@jhmartin
Copy link

https://www.consul.io/docs/agent/http.html under 'Consistency Modes'

@evan2645
Copy link

@taharah
Copy link
Member

taharah commented Jan 11, 2017

@jhmartin does what @evan2645 provide the functionality you were looking for?

@maxvt
Copy link
Contributor

maxvt commented Mar 22, 2017

https://www.consul.io/docs/agent/http.html says "most read query endpoints support specifying consistency". At the very least, this option would be useful for service and health API endpoints, because for service discovery being consistent is often less important than getting at least some results right.

For more context, see https://stripe.com/blog/service-discovery-at-stripe.

Consul v0.7.5 does not balk at those options being added to either health or catalog lookups.

@taharah taharah added this to New Features in Version 3.0.0 Apr 15, 2017
@taharah taharah added this to the 2.0.0 milestone Apr 15, 2017
@kamaradclimber
Copy link
Contributor

Any progress on that feature? Not being able to use stale makes every application based on diplomat unreliable when consul cluster does not have a leader.

@pierresouchay
Copy link
Member

Please also consider 'leader' consistency mode => which forces basic consistency over discovery endpoints

  • ?stale => allow to read from any consul server
  • ?consistent => strong consistency
  • default => consistent (but can be changed on discovery endpoints, see discovery_max_stale
  • ?leader => new in 1.0.7, allow to use old consistent method for discovery endpoints

@pierresouchay
Copy link
Member

Would you consider #165 ?

Kind regards

@pierresouchay
Copy link
Member

Now available with the changes in 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 3.0.0
New Features
Development

Successfully merging a pull request may close this issue.

6 participants