Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding Redirect on logout #234

Closed
neutronz opened this issue May 11, 2017 · 1 comment
Closed

Overriding Redirect on logout #234

neutronz opened this issue May 11, 2017 · 1 comment

Comments

@neutronz
Copy link

neutronz commented May 11, 2017

Hi there I'm using v1.5.0, devise for regular users, and rails 5.0.2, and notice that my overrides for where to redirect on logout just don't work in production environments. They redirect only to the admin login page instead of the home page.

Do you have any idea why that could be happening? I know I could probably override the base controller files but trying the concern route isn't working.

Thanks

@jamesmk
Copy link
Member

jamesmk commented May 18, 2017

Hi @neutronz,

Are you using multiple models for devise users or did you add a role to Fae::User for regular users?

I just did a test and defining after_sign_out_path_for in the ApplicationControllerConcern doesn't override the method in Fae::ApplicationController. Likely because it's a private method.

Your options would be to monkey patch Fae::ApplicationController or we could provide an logout redirect option in the Fae initializer. This would be a feature request that may not get addressed by us immediately, but we welcome PRs 😉.

thanks

@jamesmk jamesmk closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants